[release/8.0] Add support for specifying custom container run arguments #3566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for new run arguments option * Add manifest entry for runArgs * Container, not resource * Don't write manifest entry * Move extension methods to ContainerResourceBuilderExtensions and restrict to ContainerResource
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
davidfowl
approved these changes
Apr 10, 2024
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Apr 10, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3160 to release/8.0
Customer Impact
Without this change, there's no way for Aspire users to enable container features such as GPU support for AI models in containers. This effectively blocks Aspire from being used with AI model containers until merged.
Testing
New unit tests + local validation with both Docker and Podman runtimes.
Risk
Low. Adds a new annotation type, but also has new unit test coverage and local testing.
Regression?
No.
Microsoft Reviewers: Open in CodeFlow