[release/8.0] Implement IResourceWithArgs on ProjectResource #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the command line arg parsing to be the same as .NET Process's: * double quotes around single arguments * consecutive double quotes inside a quoted argument means one double quote Fix #3306
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
eerhardt
approved these changes
Apr 10, 2024
davidfowl
approved these changes
Apr 10, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3545 to release/8.0
/cc @eerhardt
Customer Impact
This is fixing 2 issues that impact customers:
.WithArgson a Project. The args get passed to the app at runtime and written to the manifest. (Note thatazddoesn't handle this correctly yet - tracking with [Issue] azd doesn't support args with Aspire on project.v0 resource Azure/azure-dev#3678)Testing
Manually tested that the
.WithArgsargs compose with the launchSettings.json command line args correctly in both VS and dotnet run.Added new automated tests for parsing.
Risk
Low to Medium-Low. It shouldn't affect any existing scenario, and fixes command line args parsing. The new scenario of specifying args to a Project may uncover more bugs than just the azd bug.
Regression?
No
Microsoft Reviewers: Open in CodeFlow