[release/8.0] Fixed issues around injecting urls #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NETCORE_URLS not working with launch profiles - Skip ASPNETCORE_URLS for endpoints that are mapped to an environment - Added tests
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
davidfowl
approved these changes
Apr 9, 2024
danmoseley
added
Servicing-approved
mitchdenny
approved these changes
Apr 10, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3492 to release/8.0
/cc @davidfowl
Customer Impact
Disabling launch profiles breaks injecting endpoints into ASPNETCORE_URLS. This means ASP.NET Core projects won't work if launch profiles are disabled even if http endpoints are added.
Testing
Added tests. Did manual tests as well (this issue was found in one of the playground samples)
Risk
Medium, this code runs by default for every project.
Regression?
Yes
Microsoft Reviewers: Open in CodeFlow