Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 2, 2024

Backport of #3338 to release/8.0

/cc @eerhardt

The new versions have specific builds for the .NETCoreApp TFM, which fixes some dependency issues like not having the 8.0.0 version of Microsoft.Bcl.AsyncInterfaces. See Xabaril/AspNetCore.Diagnostics.HealthChecks#2180.

Customer Impact

Health checks on customer apps can fail with:

fail: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[104]
      Health check azure_blob_storage threw an unhandled exception after 16.2131ms
      System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Bcl.AsyncInterfaces, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
      File name: 'Microsoft.Bcl.AsyncInterfaces, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
         at HealthChecks.Azure.Storage.Blobs.AzureBlobStorageHealthCheck.CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken)
         at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
         at HealthChecks.Azure.Storage.Blobs.AzureBlobStorageHealthCheck.CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken)
         at Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService.RunCheckAsync(HealthCheckRegistration registration, CancellationToken cancellationToken)

And the developer has no idea why Microsoft.Bcl.AsyncInterfaces can't be loaded.

Testing

I verified that an app that had the above problem no longer has it with the new HealthChecks version.

All existing tests pass.

Risk

Low. The only change in these new versions is adding .NETCoreApp TFMs to the HealthChecks packages.

Microsoft Reviewers: Open in CodeFlow

The new versions have specific builds for the .NETCoreApp TFM, which fixes some dependency issues like not having the 8.0.0 version of Microsoft.Bcl.AsyncInterfaces. See Xabaril/AspNetCore.Diagnostics.HealthChecks#2180.
@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 2, 2024
@eerhardt eerhardt merged commit 4157392 into release/8.0 Apr 3, 2024
@eerhardt eerhardt deleted the backport/pr-3338-to-release/8.0 branch April 3, 2024 17:11
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants