Skip to content

Fix flaky min rate tests #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastienros merged 1 commit into from
Mar 7, 2024
Merged

Fix flaky min rate tests #2703

sebastienros merged 1 commit into from
Mar 7, 2024

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 7, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes:

Error message
Elapsed time 00:00:00.4993570 should be greater than min read interval 00:00:00.5000000 on read.
Expected: True
Actual: False

Stack trace
at Aspire.Dashboard.Tests.ChannelExtensionsTests.GetBatchesAsync_MinReadInterval_WaitForNextRead() in /_/tests/Aspire.Dashboard.Tests/ChannelExtensionsTests.cs:line 99
--- End of stack trace from previous location ---

Microsoft Reviewers: Open in CodeFlow

@davidfowl davidfowl mentioned this pull request Mar 7, 2024
Closed
@sebastienros sebastienros merged commit 0e6e271 into main Mar 7, 2024
@sebastienros sebastienros deleted the jamesnk/flakytest-mininterval branch March 7, 2024 22:54
@sebastienros
Copy link
Member

sebastienros commented Mar 7, 2024

I merged because it's blocking other PRs, can only be better

@sebastienros sebastienros mentioned this pull request Mar 7, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kvenkatrajan kvenkatrajan kvenkatrajan approved these changes

@drewnoakes drewnoakes Awaiting requested review from drewnoakes

@tlmii tlmii Awaiting requested review from tlmii

@adamint adamint Awaiting requested review from adamint

Assignees

No one assigned

Labels

area-dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamesNK @sebastienros @kvenkatrajan