Skip to content

Fix exception when app host has no ASPNETCORE_URLS #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix exception when app host has no ASPNETCORE_URLS #1970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,11 @@ private async Task StartDashboardAsDcpExecutableAsync(CancellationToken cancella
throw new DistributedApplicationException("Error getting the resource service URL.", ex);
}

// Matches DashboardWebApplication.DashboardUrlDefaultValue
const string defaultDashboardUrl = "http://localhost:18888";

var otlpEndpointUrl = environmentVariables.GetString("DOTNET_DASHBOARD_OTLP_ENDPOINT_URL");
var dashboardUrls = environmentVariables.GetString("ASPNETCORE_URLS") ?? throw new DistributedApplicationException("ASPNETCORE_URLS environment variable not set.");
var dashboardUrls = environmentVariables.GetString("ASPNETCORE_URLS") ?? defaultDashboardUrl;
var aspnetcoreEnvironment = environmentVariables.GetString("ASPNETCORE_ENVIRONMENT");

dashboardExecutableSpec.Env =
Expand Down