Skip to content

Fix histogram chart calculation #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Fix histogram chart calculation #1968

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffdf7c4
Fix histogram chart calculation
JamesNK Jan 30, 2024
fd75b23
Comment
JamesNK Jan 30, 2024
a80e99f
Update src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
JamesNK Jan 30, 2024
b5273f2
Update src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
JamesNK Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,18 @@ protected override async Task OnParametersSetAsync()

private OtlpInstrument? GetInstrument()
{
var endDate = DateTime.UtcNow;
// Get more data than is being displayed. Histogram graph uses some historical data to calculate the bucket ranges.
// It's ok to get more data than is needed here. An additional date filter applied when building chart values.
var startDate = endDate.Subtract(Duration + TimeSpan.FromSeconds(30));

var instrument = TelemetryRepository.GetInstrument(new GetInstrumentRequest
{
ApplicationServiceId = ApplicationId,
MeterName = MeterName,
InstrumentName = InstrumentName,
StartTime = DateTime.UtcNow.Subtract(Duration),
EndTime = DateTime.UtcNow,
StartTime = startDate,
EndTime = endDate,
});

if (instrument == null)
Expand Down