[tests] Allow ConfigurationSchema.json tests to run out of repo #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-integrations
.. by changing the tests to expect `ConfigurationSchema.json` to be available next to the test assembly.
Both `Aspire.StackExchange.Redis.DistributedCaching`, and
`Aspire.StackExchange.Redis.OutputCaching` have
`ConfigurationSchema.json` which reference `Aspire.StackExchange.Redis`
without adding anything more.
But the tests for those two run validation for the
`Aspire.StackExchange.Redis` schema, which is already done by the main
tests. Instead of that:
- `Aspire.StackExchange.Redis` - continue doing the validation tests
- `Aspire.StackExchange.Redis.{Output,Distributed}Caching`
- Run the validation test for the schema against the the project's
own schema
- And don't check for any invalid cases since there is nothing being
added in the schema
radical
force-pushed
the
tests-repo-root
branch
from
3d4ea49 to
df4d4d0
Compare
eerhardt
approved these changes
Jan 24, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Thanks for fixing these.
Looks good. I just have one suggestion and a nit.
tests/Aspire.Azure.AI.OpenAI.Tests/Aspire.Azure.AI.OpenAI.Tests.csproj
Outdated
Show resolved
Hide resolved
...ge.Redis.DistributedCaching.Tests/Aspire.StackExchange.Redis.DistributedCaching.Tests.csproj
Show resolved
Hide resolved
eerhardt
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tests] ConformanceTests: Remove dependency on GetRepoRoot
[tests] Deploy ConfigurationSchema.json to the test output dir
[tests] Avoid redundant tests in Redis Caching tests
Microsoft Reviewers: Open in CodeFlow