Update Azure.Provisioning.Network to stable 1.0.0 and ship Aspire.Hosting.Azure.Network as stable#14986
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14986Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14986" |
There was a problem hiding this comment.
Pull request overview
Updates Azure provisioning and Aspire packages to stable releases and expands VS Code extension + playground assets to support new CLI/pipeline/debug/dashboard behaviors.
Changes:
- Bumps
Azure.Provisioning.Networkto1.0.0and updates other package versions. - Promotes Aspire VS Code extension features (pipeline
do, MCP server provider, dashboard browser options) and adjusts debug/CLI interactions. - Adds/updates multiple playground validation apphosts and Azure VNet end-to-end Bicep modules.
Reviewed changes
Copilot reviewed 164 out of 704 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| playground/polyglot/TypeScript/Aspire.Hosting.DevTunnels/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash for validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.DevTunnels/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for TS DevTunnels validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/tsconfig.json | Adds TS config for WebPubSub validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/package.json | Adds Node package manifest for WebPubSub validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/apphost.ts | Adds TS apphost exercising WebPubSub APIs |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/apphost.run.json | Adds run profile for WebPubSub validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for WebPubSub validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Storage/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Storage/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Storage/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/tsconfig.json | Adds TS config for SignalR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/package.json | Adds Node package manifest for SignalR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/apphost.ts | Adds TS apphost for SignalR emulator scenario |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/apphost.run.json | Adds run profile for SignalR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/base.ts | Adds shared core TS module (ReferenceExpression, list/dict wrappers) |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for SignalR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/tsconfig.json | Adds TS config for Search validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/package.json | Adds Node package manifest for Search validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/apphost.ts | Adds TS apphost exercising Search role assignment API |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/apphost.run.json | Adds run profile for Search validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/.modules/base.ts | Adds shared core TS module (ReferenceExpression, list/dict wrappers) |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for Search validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/tsconfig.json | Adds TS config for Redis validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/package.json | Adds Node package manifest for Redis validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/apphost.ts | Adds TS apphost exercising Managed Redis APIs |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/apphost.run.json | Adds run profile for Redis validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/.modules/base.ts | Adds shared core TS module (ReferenceExpression, list/dict wrappers) |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for Redis (+ KeyVault) validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/tsconfig.json | Adds TS config for EventHubs validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/package.json | Adds Node package manifest for EventHubs validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/apphost.ts | Adds TS apphost exercising EventHubs APIs (roles, hubs, emulator) |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/apphost.run.json | Adds run profile for EventHubs validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for EventHubs validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/tsconfig.json | Adds TS config for ACR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package.json | Adds Node package manifest for ACR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/apphost.ts | Adds TS apphost exercising ACR purge task API |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/apphost.run.json | Adds run profile for ACR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for ACR validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/tsconfig.json | Adds TS config for AppConfiguration validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/package.json | Adds Node package manifest for AppConfiguration validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/apphost.ts | Adds TS apphost exercising AppConfiguration emulator APIs |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/apphost.run.json | Adds run profile for AppConfiguration validation apphost |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.aspire/settings.json | Adds Aspire settings for AppConfiguration validation apphost |
| playground/TypeScriptAppHost/package.json | Adds tsx to devDependencies |
| playground/TypeScriptAppHost/.modules/transport.ts | Updates callback transport to support DTO writeback |
| playground/TypeScriptAppHost/.modules/base.ts | Enhances ReferenceExpression to support handle-mode serialization |
| playground/TypeScriptAppHost/.modules/.codegen-hash | Updates codegen hash |
| playground/TypeScriptAppHost/.gitignore | Ensures .aspire/ is not ignored |
| playground/TypeScriptAppHost/.aspire/settings.json | Adds Aspire settings for TS playground apphost |
| playground/Stress/Stress.AppHost/Program.cs | Updates resource command IDs + adds extra project; suppresses diagnostic |
| playground/SimplePipelines/SimplePipelines.AppHost/appsettings.json | Adds logging configuration |
| playground/SimplePipelines/SimplePipelines.AppHost/appsettings.Development.json | Adds dev logging configuration |
| playground/SimplePipelines/SimplePipelines.AppHost/SimplePipelines.AppHost.csproj | Adds new minimal Aspire apphost project |
| playground/SimplePipelines/SimplePipelines.AppHost/Properties/launchSettings.json | Adds launch settings |
| playground/SimplePipelines/SimplePipelines.AppHost/AppHost.cs | Adds simple pipelines example apphost |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/vnet.module.bicep | Adds SQL ACI subnet and output |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/sql.module.bicep | Adds SQL server + DB module |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/sql-store.module.bicep | Adds storage module for SQL deployment scripts |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/sql-nsg.module.bicep | Adds NSG for SQL subnet |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/sql-admin-identity.module.bicep | Adds module to reference SQL admin MI |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/sql-admin-identity-roles-sql-store.module.bicep | Adds RBAC assignment for SQL admin MI to storage |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/privatelink-file-core-windows-net.module.bicep | Adds private DNS zone and VNet link for file endpoint |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/privatelink-database-windows-net.module.bicep | Adds private DNS zone and VNet link for SQL endpoint |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/private-endpoints-sql-pe.module.bicep | Adds SQL private endpoint + DNS zone group |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/private-endpoints-files-pe.module.bicep | Adds storage file private endpoint + DNS zone group |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/aspire-manifest.json | Wires in SQL + private endpoints + roles modules |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/api-roles-sql.module.bicep | Adds deployment script to provision SQL user/roles |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/api-containerapp.module.bicep | Adds SQL-related env vars to container app |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/Program.cs | Adds SQL server/database resources and references |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/AzureVirtualNetworkEndToEnd.AppHost.csproj | Adds Aspire.Hosting.Azure.Sql reference |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.ApiService/Program.cs | Adds SQL client + /sql endpoint |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.ApiService/AzureVirtualNetworkEndToEnd.ApiService.csproj | Adds Aspire.Microsoft.Data.SqlClient package reference |
| playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.AppHost/Program.cs | Suppresses ASPIREEXTENSION001 diagnostic |
| playground/AspireWithJavaScript/AspireJavaScript.React/webpack.config.js | Enables source maps |
| playground/AspireWithJavaScript/AspireJavaScript.NodeApp/app.js | Adjusts 404 handler route matching |
| playground/AspireWithJavaScript/AspireJavaScript.MinimalApi/Properties/launchSettings.json | Removes Swagger launch URL entries |
| playground/AspireWithJavaScript/AspireJavaScript.MinimalApi/AppHost.cs | Removes Swagger setup + OpenAPI metadata |
| playground/AspireWithJavaScript/AspireJavaScript.AppHost/AspireJavaScript.AppHost.csproj | Suppresses ASPIREEXTENSION001 warning |
| extension/walkthrough/welcome.md | Adds VS Code walkthrough content |
| extension/walkthrough/runApp.md | Adds walkthrough step for running apphosts |
| extension/walkthrough/nextSteps.md | Adds walkthrough next steps content |
| extension/walkthrough/installCli.md | Adds walkthrough step and install commands |
| extension/walkthrough/dashboard.md | Adds walkthrough dashboard overview |
| extension/walkthrough/createProject.md | Adds walkthrough project creation step |
| extension/src/views/AspireAppHostTreeProvider.ts | Updates command mapping to new CLI resource verbs |
| extension/src/utils/settings.ts | Adds accessor for MCP registration setting |
| extension/src/utils/cliPath.ts | Reduces verbose CLI path logging |
| extension/src/utils/AspireTerminalProvider.ts | Adds IDE/workspace env vars for CLI runs |
| extension/src/types/configInfo.ts | Adds Capabilities to config info |
| extension/src/test/rpc/interactionServiceTests.test.ts | Updates tests for debug-session / terminal output paths |
| extension/src/server/rpcClient.ts | Handles stop request failures; wires terminal into InteractionService |
| extension/src/server/interactionService.ts | Adds dashboard browser integration + terminal fallback for output |
| extension/src/mcp/AspireMcpServerDefinitionProvider.ts | Adds MCP server definition provider |
| extension/src/loc/strings.ts | Adds new localized strings |
| extension/src/extension.ts | Adds do command, walkthrough commands, MCP provider registration |
| extension/src/editor/AspireEditorCommandProvider.ts | Adds debug-launch support for deploy/publish/do commands |
| extension/src/debugger/languages/python.ts | Marks Python debug extension deprecated |
| extension/src/debugger/languages/dotnet.ts | Adds explicit isDeprecated: false |
| extension/src/debugger/languages/cli.ts | Removes verbose spawn logging |
| extension/src/debugger/debuggerExtensions.ts | Supports apphost-provided debugger_properties; refactors config creation |
| extension/src/debugger/AspireDebugSession.ts | Adds CLI command routing and dashboard opening behavior |
| extension/src/dcp/types.ts | Adds debugger properties and Aspire command configuration types |
| extension/src/dcp/AspireDcpServer.ts | Accepts debugger_properties even when no extension type match |
| extension/src/commands/walkthroughCommands.ts | Adds terminal-based walkthrough command implementations |
| extension/src/commands/publish.ts | Routes publish to editor provider debug session |
| extension/src/commands/do.ts | Adds aspire do command with capability-based prompting behavior |
| extension/src/commands/deploy.ts | Routes deploy to editor provider debug session |
| extension/src/capabilities.ts | Expands capability reporting (node/browser + extension ids) |
| extension/package.nls.json | Adds command/config/walkthrough localization entries |
| extension/package.json | Adds MCP provider contribution, settings, commands, and walkthrough |
| extension/loc/xlf/aspire-vscode.xlf | Adds/updates localization strings |
| extension/README.md | Documents new command/step debug options and do command |
| eng/Versions.props | Updates .NET 10 preview package versions |
| eng/Signing.props | Adds additional assemblies to signing list |
| Directory.Packages.props | Bumps Azure.Provisioning.Network to stable + updates MCP + ARM Resources |
| Aspire.slnx | Adds SimplePipelines apphost project to solution |
Files not reviewed (8)
- playground/TypeScriptAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/package-lock.json: Language not supported
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.WebPubSub/ValidationAppHost/package-lock.json: Language not supported
Comments suppressed due to low confidence (3)
extension/src/debugger/AspireDebugSession.ts:1
closeDashboardOnDebugEndis implemented via the privatecloseDashboard()helper, butdispose()never calls it. As a result, dashboard debug browser sessions won't be stopped when the Aspire debug session ends. Callthis.closeDashboard()during disposal/shutdown (before clearing state) to apply the setting.
import * as vscode from "vscode";
extension/src/server/interactionService.ts:1
IInteractionServiceaddscloseDashboard, butaddInteractionServiceEndpointsdoes not register acloseDashboardrequest handler. If the CLI starts calling this RPC method it will fail at runtime. Either (a) wire upconnection.onRequest("closeDashboard", ...)and implement behavior, or (b) removecloseDashboardfrom the interface until the protocol supports it end-to-end.
import { MessageConnection } from 'vscode-jsonrpc';
extension/src/capabilities.ts:1
- Appending every installed VS Code extension ID into the capabilities list can significantly inflate
ASPIRE_EXTENSION_CAPABILITIES(environment variable), risking OS env-size limits (notably on Windows) and increasing startup overhead. Consider limiting this to a curated subset (e.g., only extensions relevant to debugging) or sending extension IDs via a different channel (RPC/config request) rather than an env var.
import * as vscode from 'vscode';
b002795 to
b654b0f
Compare
…ting.Azure.Network as stable - Update Azure.Provisioning.Network from 1.0.0-beta.3 to 1.0.0 (stable) - Remove SuppressFinalPackageVersion from Aspire.Hosting.Azure.Network csproj so the package ships as a stable release - Add DisablePackageBaselineValidation since this is the first stable release and there is no prior baseline to validate against - Add assembly-level [Experimental(ASPIREAZURE003)] attribute to Aspire.Hosting.Azure.Network so consumers get an experimental warning - Add #pragma warning disable ASPIREAZURE003 to files in Aspire.Hosting.Azure.Sql, tests, and playground that consume the now-experimental assembly - This is needed because Aspire.Hosting.Azure.Sql depends on Aspire.Hosting.Azure.Network and cannot ship stable with a prerelease dependency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b654b0f to
eddce4f
Compare
sebastienros
left a comment
There was a problem hiding this comment.
Why do we need to mark internal types experimental?
It's more appropriate than suppressing the diagnostic. Because if some other code tries to call It's like nullable annotations. Instead of just suppressing |
…ting.Azure.Network as stable (dotnet#14986) * Update Azure.Provisioning.Network to stable 1.0.0 and ship Aspire.Hosting.Azure.Network as stable - Update Azure.Provisioning.Network from 1.0.0-beta.3 to 1.0.0 (stable) - Remove SuppressFinalPackageVersion from Aspire.Hosting.Azure.Network csproj so the package ships as a stable release - Add DisablePackageBaselineValidation since this is the first stable release and there is no prior baseline to validate against - Add assembly-level [Experimental(ASPIREAZURE003)] attribute to Aspire.Hosting.Azure.Network so consumers get an experimental warning - Add #pragma warning disable ASPIREAZURE003 to files in Aspire.Hosting.Azure.Sql, tests, and playground that consume the now-experimental assembly - This is needed because Aspire.Hosting.Azure.Sql depends on Aspire.Hosting.Azure.Network and cannot ship stable with a prerelease dependency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix up experimental annotation --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
Update
Azure.Provisioning.Networkfrom1.0.0-beta.3to the stable1.0.0release, and shipAspire.Hosting.Azure.Networkas a stable package.Changes
Azure.Provisioning.Networkversion from1.0.0-beta.3to1.0.0.SuppressFinalPackageVersionso the package ships as stable. AddDisablePackageBaselineValidationsince this is the first stable release and there is no prior baseline to validate against.Motivation
Aspire.Hosting.Azure.Sqldepends onAspire.Hosting.Azure.Networkand cannot ship as stable with a prerelease dependency. Now thatAzure.Provisioning.Networkhas a stable 1.0.0 release, we can promoteAspire.Hosting.Azure.Networkto stable as well.Checklist