Merged
Conversation
Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Unquarantine stable tests with zero failures
[automated] Unquarantine stable tests
Mar 2, 2026
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14862Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14862" |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes quarantine markers from previously flaky tests that have been stable long enough to re-enter the normal test suite.
Changes:
- Removed
[QuarantinedTest]from twoCliOrphanDetectorTeststest methods. - Removed
[QuarantinedTest]from the Cosmos DB emulator functional test. - Cleaned up an unused
using Aspire.TestUtilities;inCliOrphanDetectorTests.cs(no longer needed after attribute removal).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/Cli/CliOrphanDetectorTests.cs | Unquarantines two CLI orphan detector tests by removing [QuarantinedTest] attributes. |
| tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs | Unquarantines Cosmos emulator functional test by removing [QuarantinedTest] attribute. |
tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs
Show resolved
Hide resolved
JamesNK
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
[QuarantinedTest]from three tests that have had 25+ days of quarantine run data with zero failures, making them eligible to rejoin the standard test suite.Changes
[QuarantinedTest]fromAzureCosmosDBEmulatorFunctionalTests.VerifyWaitForOnCosmosDBEmulatorBlocksDependentResources(tracked: Failing test: Aspire.Hosting.Azure.Tests.AzureCosmosDBEmulatorFunctionalTests.VerifyWaitForOnCosmosDBEmulatorBlocksDependentResources #14099)[QuarantinedTest]fromCliOrphanDetectorTests.CliOrphanDetectorAfterTheProcessWasRunningForAWhileThenStops(tracked: Failing test: Aspire.Cli.Tests.CliOrphanDetectorTests.CliOrphanDetectorAfterTheProcessWasRunningForAWhileThenStops #12472)[QuarantinedTest]fromCliOrphanDetectorTests.CliOrphanDetectorContinuesRunningWhenProcessAliveWithCorrectStartTime(tracked: Failing test: Aspire.Cli.Tests.CliOrphanDetectorTests.CliOrphanDetectorContinuesRunningWhenProcessAliveWithCorrectStartTime #12710)using Aspire.TestUtilities;inAzureCosmosDBEmulatorFunctionalTests.csthat was inadvertently dropped by QuarantineTools when removing the attributeFixes #14099
Fixes #12472
Fixes #12710
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.