Add polyglot exports for AppContainers#14758
Merged
davidfowl merged 6 commits intorelease/13.2from Mar 3, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14758Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14758" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Aspire’s polyglot (ATS/TypeScript AppHost) support for Azure App Containers by adding new export coverage and improving ATS scanning/codegen so TypeScript AppHosts can use more of the integration surface.
Changes:
- Added ATS capability scanner support for assembly-level
[AspireExport(typeof(T))]and improved Unknown→Handle resolution for callback parameter/return types. - Fixed TypeScript codegen for multi-parameter callback argument destructuring typing.
- Added
[AspireExport]/[AspireExportIgnore]annotations across Azure App Containers APIs and introduced a TypeScript ValidationAppHost for the integration.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting/Ats/AtsCapabilityScanner.cs | Adds assembly-level export scanning + resolves callback param/return types during Unknown-type resolution. |
| src/Aspire.Hosting.CodeGeneration.TypeScript/AtsTypeScriptCodeGenerator.cs | Fixes TS typing for multi-parameter callback destructuring. |
| src/Aspire.Hosting.Azure/AzureResourceInfrastructure.cs | Exports AzureResourceInfrastructure for polyglot callback contexts. |
| src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs | Adds export/ignore annotations and a polyglot-friendly scheduled job export overload. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppProjectExtensions.cs | Exports publishAsAzureContainerApp for projects. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs | Exports environment/naming/dashboard/HTTPS/log-analytics configuration APIs; ignores obsolete infra API. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExecutableExtensions.cs | Exports publishAsAzureContainerApp for executables. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppContainerExtensions.cs | Exports publishAsAzureContainerApp for containers. |
| src/Aspire.Hosting.Azure.AppContainers/AtsTypeMappings.cs | Adds assembly-level ATS export for external ContainerApp type. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/* | Adds a new TypeScript ValidationAppHost for App Containers integration. |
| playground/polyglot/TypeScript/.../ValidationAppHost/.modules/* | Commits generated TypeScript SDK output (codegen artifacts). |
| .gitignore | Stops ignoring .modules/ under playground, increasing risk of committing generated SDK artifacts. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/package-lock.json: Language not supported
.../polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/aspire.ts
Show resolved
Hide resolved
src/Aspire.Hosting.CodeGeneration.TypeScript/AtsTypeScriptCodeGenerator.cs
Show resolved
Hide resolved
76 tasks
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22589002542 |
This was referenced Feb 27, 2026
sebastienros
force-pushed
the
sebros/polyglot-appcontainers
branch
from
d4c6f51 to
4ad1888
Compare
…ot-appcontainers # Conflicts: # tests/Aspire.Hosting.CodeGeneration.Go.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.go # tests/Aspire.Hosting.CodeGeneration.Java.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.java # tests/Aspire.Hosting.CodeGeneration.Python.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.py # tests/Aspire.Hosting.CodeGeneration.Rust.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.rs
This was referenced Feb 28, 2026
Avoid generating/ registering CancellationToken as a handle wrapper in Go, Java, and Rust generators, and update snapshots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Mar 3, 2026
davidfowl
reviewed
Mar 3, 2026
| types = ex.Types.Where(t => t != null).ToArray()!; | ||
| } | ||
|
|
||
| // Process assembly-level [AspireExport(typeof(T))] attributes for cross-assembly type exports |
Member
There was a problem hiding this comment.
Let's mark this down in the readme. We'll need to understand what it means when multiple assemblies do this.
davidfowl
approved these changes
Mar 3, 2026
Member
|
@sebastienros see the feedback on the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069