Fix port mismatch for bait-and-switch resources in Kubernetes publisher (13.2)#14627
Open
mitchdenny wants to merge 6 commits intorelease/13.2from
Open
Fix port mismatch for bait-and-switch resources in Kubernetes publisher (13.2)#14627mitchdenny wants to merge 6 commits intorelease/13.2from
mitchdenny wants to merge 6 commits intorelease/13.2from
Conversation
Member
Author
|
/deployment-test |
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14627Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14627" |
Contributor
|
🚀 Deployment tests starting on PR #14627... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a cherry-pick of #14590 targeting the release/13.2 branch. It fixes a port mismatch bug in the Kubernetes publisher that occurs when resources are replaced during the "bait-and-switch" pattern (e.g., when PublishAsDockerFile() replaces an ExecutableResource with an ExecutableContainerResource). The fix applies the same ResourceNameComparer pattern already used successfully by the Docker Compose, Azure App Service, and Azure Container Apps publishers.
Changes:
- Modified
KubernetesEnvironmentContextto useResourceNameComparerfor resource dictionary lookups by name instead of object identity - Added comprehensive test coverage with snapshot verification for the bait-and-switch scenario
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Kubernetes/KubernetesEnvironmentContext.cs | Added ResourceNameComparer to the _kubernetesComponents dictionary to enable name-based resource lookups |
| tests/Aspire.Hosting.Kubernetes.Tests/KubernetesPublisherTests.cs | Added new test KubernetesMapsPortsForBaitAndSwitchResources to verify consistent port allocation |
| tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/*.verified.yaml | Seven snapshot files verifying correct YAML generation with consistent port 8000 across all configurations |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22327060851 |
Contributor
|
❌ Deployment E2E Tests failed Summary: 22 passed, 1 failed, 0 cancelled Passed Tests
Failed Tests
🎬 Terminal Recordings
|
10 tasks
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14590 targeting release/13.2 for deployment testing.
Description
The Kubernetes publisher uses a
Dictionarycache inKubernetesEnvironmentContextkeyed by object identity. WhenPublishAsDockerFile()replaces anExecutableResourcewith anExecutableContainerResource(the "bait and switch" pattern), other resources still holdEndpointReferenceobjects pointing to the original. The cache misses on the original vs replacement, creating twoKubernetesResourceobjects for the same logical resource, each allocating a different port from the sharedPortAllocator. This causes the referencing resource to get a different port than the one in the service/deployment YAML.The fix applies the same
ResourceNameComparerpattern already used by the Docker Compose, Azure App Service, and Azure Container Apps publishers.Fixes #9226
Based on community PR #14590 by @bbartels