Add [Experimental] attribute to WithCompactResourceNaming API#14583
Merged
mitchdenny merged 1 commit intorelease/13.2from Feb 23, 2026
Merged
Add [Experimental] attribute to WithCompactResourceNaming API#14583mitchdenny merged 1 commit intorelease/13.2from
mitchdenny merged 1 commit intorelease/13.2from
Conversation
Copilot
AI
changed the title
[WIP] Add experimental attribute to new API with unique number
Add [Experimental] attribute to WithCompactResourceNaming API
Feb 19, 2026
eerhardt
reviewed
Feb 19, 2026
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
eerhardt
force-pushed
the
copilot/add-experimental-attribute-api
branch
from
897c2cd to
9841520
Compare
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14583Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14583" |
eerhardt
approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks the recently introduced WithCompactResourceNaming() API as experimental by adding the [Experimental] attribute with diagnostic ID ASPIREACANAMING001. This follows the established pattern for Azure Container App experimental APIs (similar to ASPIREACADOMAINS001 for custom domains).
Changes:
- Added
[Experimental("ASPIREACANAMING001", UrlFormat = "https://aka.ms/aspire/diagnostics/{0}")]attribute to theWithCompactResourceNamingextension method - Added
#pragma warning disable ASPIREACANAMING001to test fileAzureContainerAppsTests.csto suppress warnings for test code using the experimental API - Added
using System.Diagnostics.CodeAnalysisdirective to support theExperimentalattribute
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs | Added [Experimental] attribute to WithCompactResourceNaming() method and required using statement |
| tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs | Added pragma directive to suppress experimental API warning in unit tests |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22233861262 |
joperezr
approved these changes
Feb 23, 2026
3 tasks
Copilot AI
added a commit
that referenced
this pull request
Mar 10, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks the
WithCompactResourceNaming()API introduced in #14442 as experimental with diagnostic IDASPIREACANAMING001, following the existing naming convention (e.g.,ASPIREACADOMAINS001).[Experimental("ASPIREACANAMING001", UrlFormat = "https://aka.ms/aspire/diagnostics/{0}")]toWithCompactResourceNaming#pragma warning disablein test file that calls the APIChecklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.