[Automated] Backmerge release/13.2 to main#14521
Merged
Conversation
* Fix Spectre markup rendering in CLI selection prompts The blanket EscapeMarkup() added to the UseConverter in PromptForSelectionAsync/PromptForSelectionsAsync (PR #14422) escaped all markup including the intentional [bold]...[/] used by AddCommand.PackageNameWithFriendlyNameIfAvailable, causing literal '[bold]postgresql[/]' to appear in 'aspire add' output. Fix: remove blanket escaping from the generic converter and instead escape dynamic values at each caller site that formats user-controlled or file-system content (file paths, package names, channel details, publish prompt options), while preserving intentional Spectre markup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ease-13.2-to-main
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14521Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14521" |
joperezr
approved these changes
Feb 17, 2026
Contributor
Author
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22107541286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Backmerge
This PR merges changes from
release/13.2back intomain.Commits to merge: 3
This PR was created automatically to keep
mainup-to-date with release branch changes.Once approved, please merge using a merge commit (not squash or rebase).
This PR was generated by the backmerge-release workflow.