Skip to content

Make Ubuntu runner not identify as WSL2#14440

Merged
davidfowl merged 5 commits intomainfrom
danegsta/certTrustError
Feb 11, 2026
Merged

Make Ubuntu runner not identify as WSL2#14440
davidfowl merged 5 commits intomainfrom
danegsta/certTrustError

Conversation

@danegsta
Copy link
Member

@danegsta danegsta commented Feb 11, 2026

Description

Ensure our Ubuntu runner doesn't try to exercise a broken WSL code path in dotnet dev-certs https --trust.

Copilot AI review requested due to automatic review settings February 11, 2026 01:40
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14440

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14440"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI reusable test workflow to alter the environment for the Linux “Trust HTTPS development certificate” step, aiming to avoid .NET treating the runner like WSL2 and/or failing certificate trust.

Changes:

  • Sets WSL_INTEROP (empty) for the dotnet dev-certs https --trust step on ubuntu-latest.

@danegsta danegsta changed the title Try making dotnet not identify github as WSL2, ignore trust error Make Ubuntu runner not identify as WSL2 Feb 11, 2026
@danegsta danegsta enabled auto-merge (squash) February 11, 2026 02:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit e7763d6:

Test Recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View Recording
Banner_DisplayedOnFirstRun ▶️ View Recording
Banner_DisplayedWithExplicitFlag ▶️ View Recording
CreateAndDeployToDockerCompose ▶️ View Recording
CreateAndDeployToDockerComposeInteractive ▶️ View Recording
CreateAndPublishToKubernetes ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateEmptyAppHostProject ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
LogsCommandShowsResourceLogs ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording
ResourcesCommandShowsRunningResources ▶️ View Recording

📹 Recordings uploaded automatically from CI run #21890216925

@davidfowl davidfowl disabled auto-merge February 11, 2026 02:47
@davidfowl davidfowl merged commit bc92f06 into main Feb 11, 2026
338 of 339 checks passed
@davidfowl davidfowl deleted the danegsta/certTrustError branch February 11, 2026 02:47
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Feb 11, 2026
JamesNK pushed a commit that referenced this pull request Feb 25, 2026
* Try making dotnet not identify github as WSL2, ignore trust error

* Skip on error

* Remove continue-on-error since workaround was successful

* Allow exit code 4

* Add comment explaining workaround
joperezr added a commit that referenced this pull request Feb 26, 2026
…or change (#14698)

* Fix template version parsing for .NET 10.0 SDK separator change (#14285)

* Initial plan

* Fix template version parsing to support @ separator for .NET 10.0 SDK

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

* Refactor into parameterized test using Theory and InlineData

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

* Fix

* Update pinned SDK version to 10.0.102 (#13936)

* Initial plan

* Update SDK version from 10.0.101 to 10.0.102

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

* Apply suggestions from code review

* Make Ubuntu runner not identify as WSL2 (#14440)

* Try making dotnet not identify github as WSL2, ignore trust error

* Skip on error

* Remove continue-on-error since workaround was successful

* Allow exit code 4

* Add comment explaining workaround

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants