-
Notifications
You must be signed in to change notification settings - Fork 815
Suppress banner display for aspire --version
#14350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f538952
Initial plan
Copilot ecfec3c
Suppress banner when --version flag is used
Copilot 775ce92
Exclude telemetry from informational commands, add tests
JamesNK cd2f3e4
Clean up
JamesNK 364b5fd
Fix test?
JamesNK ab560e1
Fix test?
JamesNK 74f9082
Fix test?
JamesNK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Aspire.Cli; | ||
|
|
||
| /// <summary> | ||
| /// Common command-line option names used for manual argument checks. | ||
| /// </summary> | ||
| internal static class CommonOptionNames | ||
| { | ||
| public const string Version = "--version"; | ||
| public const string VersionShort = "-v"; | ||
| public const string Help = "--help"; | ||
| public const string HelpShort = "-h"; | ||
| public const string HelpAlt = "-?"; | ||
| public const string NoLogo = "--nologo"; | ||
| public const string Banner = "--banner"; | ||
| public const string Debug = "--debug"; | ||
| public const string DebugShort = "-d"; | ||
| public const string NonInteractive = "--non-interactive"; | ||
| public const string WaitForDebugger = "--wait-for-debugger"; | ||
| public const string CliWaitForDebugger = "--cli-wait-for-debugger"; | ||
|
|
||
| /// <summary> | ||
| /// Options that represent informational commands (e.g. --version, --help) which should | ||
| /// opt out of telemetry and suppress first-run experience. | ||
| /// </summary> | ||
| public static readonly string[] InformationalOptionNames = [Version, Help, HelpShort, HelpAlt]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.