[release/13.1] Fix Aspire.ProjectTemplates build failure from command line length limits #14009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added System.CommandLine package directive to replace-text.cs - Rewrote the script to use System.CommandLine's Option and RootCommand APIs - System.CommandLine automatically supports .rsp files via @ prefix - Updated Aspire.ProjectTemplates.csproj to generate .rsp file with arguments - Changed script invocation to pass .rsp file instead of command-line arguments - This prevents command line length issues when building templates on Windows Co-authored-by: DamianEdwards <[email protected]>
- Replace Environment.Exit() calls with proper return statements - Add try-catch block around the entire action handler - Return exit codes from the action handler instead of calling Environment.Exit() - This allows proper cleanup and makes the script more testable Co-authored-by: DamianEdwards <[email protected]>
…I expanding .rsp The dotnet CLI itself uses System.CommandLine and expands .rsp files before passing arguments, which means we still hit the command line limit when using 'dotnet script.cs'. Now the build process: 1. Builds the script to an executable using 'dotnet build' 2. Runs the compiled executable directly with '@response.rsp' 3. This avoids the dotnet CLI intermediary and prevents .rsp expansion The compiled executable is placed in artifacts/bin/replace-text/Debug/ Co-authored-by: DamianEdwards <[email protected]>
Co-authored-by: DamianEdwards <[email protected]>
Per feedback, the simpler approach is to use 'dotnet script.cs -- @response.rsp' where the '--' tells dotnet CLI to pass arguments directly to the script without interpretation. This avoids the CLI expanding the .rsp file and hitting command line limits. The script still needs to be built once (dotnet does this automatically when running .cs files), so we keep the build step to ensure it's compiled before use. Co-authored-by: DamianEdwards <[email protected]>
The build step is not needed. When using 'dotnet script.cs -- @response.rsp', dotnet automatically compiles and caches the script as needed. The explicit build step was redundant. Co-authored-by: DamianEdwards <[email protected]>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14009Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14009" |
eerhardt
approved these changes
Jan 20, 2026
radical
approved these changes
Jan 20, 2026
joperezr
reviewed
Jan 20, 2026
| // Validate paths | ||
| if (paths.Count == 0) | ||
| { | ||
| Console.Error.WriteLine("Error: No file paths provided. Use --files to specify paths."); |
Member
There was a problem hiding this comment.
Pretty minor, I'm assuming System.CommandLine validates this but we are losing this custom error that provides a useful hint, but I guess that's ok.
joperezr
reviewed
Jan 20, 2026
| <CommandArgs Include="--replacements" /> | ||
| <CommandArgs Include="$(ReplacementsArgs)" /> | ||
| <_RspLines Include="--files" /> | ||
| <_RspLines Include="@(SourceFiles)" /> |
Member
There was a problem hiding this comment.
@DamianEdwards might be worth to consider this in main
Member
There was a problem hiding this comment.
.rsp files are line delimited, so there is no need to quote paths since the whole path is on a single line and the whole line is treated as a single string.
Member
|
Left a couple of nits, but this looks good otherwise and it is really just tell mode given it is infra only. |
joperezr
approved these changes
Jan 20, 2026
Member
|
@joperezr thanks, but I can't merge this 😄 |
This was referenced Feb 11, 2026
This was referenced Feb 12, 2026
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13578 to release/13.1
/cc @DamianEdwards @copilot
Customer Impact
Testing
Risk
Regression?