[release/13.1] Filter dev certs without X509SubjectKeyIdentifierExtension when any cert has it#13676
Merged
joperezr merged 2 commits intorelease/13.1from Jan 20, 2026
Merged
Conversation
…ny cert has it Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13676Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13676" |
danegsta
approved these changes
Jan 15, 2026
Member
|
@joperezr Does it need to be merged? |
Member
|
Yes, this was waiting on reviews IIRC. We will merge it today |
joperezr
approved these changes
Jan 20, 2026
This was referenced Feb 11, 2026
This was referenced Feb 12, 2026
Open
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13667 to release/13.1
/cc @danegsta @copilot
Customer Impact
The OpenSSL implementation used by some services (reproduces with Node.JS based apps) doesn't handle the situation where multiple generations of dev cert are trusted, but one of them is missing a Subject Key Identifier ASN.1 extension (it was added to the dev cert in SDK 10.0.101). If a dev cert without the extension is in the trusted set, Node.JS apps seem to always try to validate against it regardless of the actual dev cert used by the target server, breaking the ability to trust the newer dev cert.
This PR excludes older certificates from the default trusted set when newer generation certificates are present.
Testing
Existing and manual testing.
Risk
Long running non-Aspire applications using older dev certs won't be trusted by Aspire services. Aspire and services it launches will use the newest developer certificate.
Regression?
No