Better interactions provider workaround fix #12991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
adamint,
captainsafia,
davidfowl,
eerhardt and
mitchdenny
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12991Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12991" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines a workaround for a FluentUI Blazor bug by moving a 2-second startup delay from the interaction watcher task to the dialog display task. This change ensures message bar notifications are displayed immediately while only delaying dialog display, reducing the impact of the workaround.
Key changes:
- Moved the 2-second delay from
WatchInteractionsAsynctoInteractionsDisplayAsync - Updated the comment to clarify that the delay only impacts dialogs, not message bars
- Allows message bar notifications to be shown immediately without delay
JamesNK
force-pushed
the
jamesnk/interaction-provider-better-workaround
branch
from
c047d03 to
a423e6e
Compare
Member
Author
|
I'm working on a FluentUI fix - microsoft/fluentui-blazor#4324 We should be able to remove it for 13.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix delayed displaying message bar notifications. This fix narrows the impact to only delay displaying dialogs.