Skip to content

Conversation

@karolz-ms
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12688

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12688"

@karolz-ms
Copy link
Member Author

@copilot please create a backport PR for this into release/13.0 branch

Copy link
Contributor

Copilot AI commented Nov 5, 2025

@karolz-ms I've opened a new pull request, #12689, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes NetworkIdentifier from a readonly record struct (value type) to a record class (reference type).

Key Changes

  • Converted NetworkIdentifier from readonly record struct to record (class)

@karolz-ms karolz-ms enabled auto-merge (squash) November 5, 2025 01:42
@karolz-ms
Copy link
Member Author

/backport to release/13.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19088540817

@karolz-ms karolz-ms merged commit 7932dea into main Nov 6, 2025
302 of 303 checks passed
@karolz-ms karolz-ms deleted the dev/karolz/network-identifier branch November 6, 2025 05:11
@dotnet-policy-service dotnet-policy-service bot added this to the 13.1 milestone Nov 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants