-
Notifications
You must be signed in to change notification settings - Fork 768
Fix generating random MCP endpoint URL in templates #12558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12558Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12558" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds MCP (Model Context Protocol) endpoint configuration to Aspire project templates. MCP endpoints are configured similarly to existing OTLP endpoints with both HTTP and HTTPS variants.
- Adds port configuration parameters for MCP HTTP (18000) and HTTPS (23000) endpoints across all templates
- Updates template configuration files to support user-specified or auto-generated MCP ports
- Adds MCP endpoint environment variables to launch settings
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/template.json |
Adds MCP HTTP/HTTPS port parameters with generation and coalescing logic |
src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/dotnetcli.host.json |
Hides MCP port parameters from CLI interface |
src/Aspire.ProjectTemplates/templates/aspire-py-starter/13.0/apphost.run.json |
Adds MCP endpoint environment variable configuration |
src/Aspire.ProjectTemplates/templates/aspire-py-starter/.template.config/template.json |
Adds MCP HTTP/HTTPS port parameters with generation and coalescing logic |
src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/template.json |
Adds MCP HTTP/HTTPS port parameters with generation and coalescing logic |
src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/dotnetcli.host.json |
Hides MCP port parameters from CLI interface |
src/Aspire.ProjectTemplates/templates/aspire-apphost/.template.config/template.json |
Adds MCP HTTP/HTTPS port parameters with generation and coalescing logic |
src/Aspire.ProjectTemplates/templates/aspire-apphost/.template.config/dotnetcli.host.json |
Hides MCP port parameters from CLI interface |
src/Aspire.ProjectTemplates/templates/aspire-apphost-singlefile/.template.config/template.json |
Adds MCP HTTP/HTTPS port parameters with generation and coalescing logic |
src/Aspire.ProjectTemplates/templates/aspire-apphost-singlefile/.template.config/dotnetcli.host.json |
Hides MCP port parameters from CLI interface |
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/18986770305 |
|
I made this PR at the end of the day and didn't test it before signing off. Does it work? |
|
I did, yes it does. |
Description
ASPIRE_DASHBOARD_MCP_ENDPOINT_URLvalues had previously been added to template'slaunchSettings.json. However config wasn't added to templates to generate a random value for the endpoint when a template was created.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate