-
Notifications
You must be signed in to change notification settings - Fork 765
Fix MCP endpoint with redirect HTTPS #12556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12556Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12556" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for MCP (Model Context Protocol) endpoint to work with HTTP-only configuration, ensuring that HTTPS redirection is only enabled when all endpoints (Frontend, OTLP gRPC, OTLP HTTP, and MCP) are using HTTPS.
Key changes:
- Updated the
isAllHttpscheck to include the MCP endpoint when determining whether to enable HTTPS redirection - Added a test to verify that the MCP endpoint works correctly when configured with HTTP while other endpoints use HTTPS
- Introduced a local variable to improve code readability when iterating over grouped endpoints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Dashboard/DashboardWebApplication.cs | Added MCP endpoint to the HTTPS check and extracted grouped endpoints to a local variable |
| tests/Aspire.Dashboard.Tests/Integration/McpServiceTests.cs | Added test case to verify MCP endpoint works with HTTP-only configuration |
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/18969710303 |
Description
Fix dashboard configuration error when MCP endpoint is the only non-HTTPS endpoint.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate