Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

The SkipPlaygroundProjects parameter was added in eng/Build.props and is used in localhive.sh, but wasn't applied to the build-packages workflow. This causes unnecessary builds of playground projects during package creation.

Changes

  • Added -p:SkipPlaygroundProjects=true to the build command in .github/workflows/build-packages.yml

This aligns with the existing -p:SkipTestProjects=true usage and prevents playground projects (which are for development/testing only) from being built during package builds.

- name: Build with packages
  run: ./build.sh -restore -build -build-extension -ci -pack -bl -p:InstallBrowsersForPlaywright=false -p:SkipTestProjects=true -p:SkipPlaygroundProjects=true ${{ inputs.versionOverrideArg }}
Original prompt

We added SkipPlaygroundProjects in cbab0e7 to skip it during a call to build.sh. Use it

run: ./build.sh -restore -build -build-extension -ci -pack -bl -p:InstallBrowsersForPlaywright=false -p:SkipTestProjects=true ${{ inputs.versionOverrideArg }}
to skip packing playground projects


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update build workflow to skip packing playground projects Skip playground projects in build-packages workflow Oct 31, 2025
Copilot AI requested a review from davidfowl October 31, 2025 04:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12547

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12547"

@davidfowl davidfowl marked this pull request as ready for review October 31, 2025 04:14
Copilot AI review requested due to automatic review settings October 31, 2025 04:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the package build workflow by skipping playground projects during the package build process. Since playground projects are not needed for package generation, excluding them reduces build time and resource usage.

Key Changes

  • Added -p:SkipPlaygroundProjects=true flag to the build command in the package build workflow

@davidfowl davidfowl enabled auto-merge (squash) October 31, 2025 04:26
@davidfowl davidfowl merged commit 56f77a1 into main Oct 31, 2025
589 of 595 checks passed
@davidfowl davidfowl deleted the copilot/skip-packing-playground-projects branch October 31, 2025 05:16
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 31, 2025
@davidfowl
Copy link
Member

/backport to release/13.0

@github-actions
Copy link
Contributor

Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/18963542719

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants