Skip to content

Ensure OutputPath is created in ResourceContainerImageBuilder #11831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

Ensure OutputPath is created in ResourceContainerImageBuilder #11831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Aspire.Hosting/Publishing/ResourceContainerImageBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,12 @@ private async Task BuildContainerImageFromDockerfileAsync(string resourceName, D
resolvedBuildSecrets[buildSecret.Key] = await ResolveValue(buildSecret.Value, cancellationToken).ConfigureAwait(false);
}

// ensure outputPath is created if specified since docker/podman won't create it for us
if (options?.OutputPath is { } outputPath)
{
Directory.CreateDirectory(outputPath);
}

if (publishingTask is not null)
{
await using (publishingTask.ConfigureAwait(false))
Expand Down
4 changes: 2 additions & 2 deletions tests/Aspire.Hosting.Tests/Publishing/ResourceContainerImageBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,11 @@ public async Task CanBuildImageFromDockerfileResource_WithAllOptionsSet()

using var app = builder.Build();

var tempOutputPath = Path.GetTempPath();
using var tempDir = new TempDirectory();
var options = new ContainerBuildOptions
{
ImageFormat = ContainerImageFormat.Oci,
OutputPath = tempOutputPath,
OutputPath = Path.Combine(tempDir.Path, "NewFolder"), // tests that the folder is created if it doesn't exist
TargetPlatform = ContainerTargetPlatform.LinuxAmd64
};

Expand Down