[release/9.5] Adapt OpenAI health check based on endpoint configuration #11792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…source Co-authored-by: davidfowl <[email protected]>
…Check Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…HealthAsync methods Co-authored-by: davidfowl <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: sebastienros <[email protected]>
Co-authored-by: davidfowl <[email protected]>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11792Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11792" |
joperezr
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Low Risk, approved.
@davidfowl should we add a test here to validate it?
|
Its unclear how to add a non flaky one. We can test the health check itself #11763 (comment) |
davidfowl
approved these changes
Oct 3, 2025
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
Open
Open
Open
Open
Open
Open
Open
⬆️ .NET: Bump Aspire.Hosting.AppHost from 9.4.0 to 9.5.2
PothieuG/SSW_x_Vonage_Clean_Architecture#12
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11763 to release/9.5
/cc @davidfowl @copilot
Customer Impact
The healthcheck for the open ai resource always uses the official open ai status page even when the endpoint is changed to another open ai compatible endpoint.
Testing
Manually verified.
Risk
Low, affects the open ai hosting integration.
Regression?
No