-
Notifications
You must be signed in to change notification settings - Fork 715
Fix CommandLineArgsCallbackContext ExecutionContext in AzureResourcePreparer and prevent WithVSCodeDebugSupport execution in publish mode #11783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidfowl
merged 6 commits into
main
from
copilot/fix-8b19d83e-56ad-4cbd-9b34-b7e1c4d6258e
Oct 1, 2025
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8afc522
Initial plan
Copilot e5ffe9f
Fix CommandLineArgsCallbackContext ExecutionContext in AzureResourceP…
Copilot 1348d79
Only execute WithVSCodeDebugSupport in run mode
Copilot e744326
Update src/Aspire.Hosting/ResourceBuilderExtensions.cs
davidfowl 72ae992
Add tests for WithVSCodeDebugSupport behavior in publish mode
Copilot d421906
Address PR feedback: revert formatting and improve test
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -235,6 +235,38 @@ public async Task NullCommandLineArgIsIgnored() | |
| Assert.True(true); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task CommandLineArgsCallbackContextHasCorrectExecutionContextDuringPublish() | ||
| { | ||
| using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish); | ||
| builder.AddAzureContainerAppEnvironment("env"); | ||
|
|
||
| // Create a project with a WithArgs callback that checks IsRunMode before accessing ServiceProvider | ||
| // This simulates what WithVSCodeDebugSupport does | ||
| var api = builder.AddProject<Project>("api", launchProfileName: null) | ||
| .WithArgs(context => | ||
| { | ||
| // This simulates WithVSCodeDebugSupport behavior - checking IsRunMode before accessing ServiceProvider | ||
| if (!context.ExecutionContext.IsRunMode) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| // This should not be reached during publish mode, but if the ExecutionContext is not set correctly, | ||
| // it will default to Run mode and then try to access ServiceProvider which will throw | ||
| _ = context.ExecutionContext.ServiceProvider; | ||
|
||
| }); | ||
|
|
||
| using var app = builder.Build(); | ||
|
|
||
| // This should not throw because ExecutionContext should be set to Publish mode | ||
| // and the IsRunMode check should prevent accessing ServiceProvider | ||
| await ExecuteBeforeStartHooksAsync(app, default); | ||
|
|
||
| // Test passes if we reach this point without exceptions | ||
| Assert.True(true); | ||
| } | ||
|
|
||
| private sealed class Project : IProjectMetadata | ||
| { | ||
| public string ProjectPath => "project"; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.