[release/9.5] Update Microsoft.Extensions.AI packages, use content env var #11726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
eerhardt,
radical and
sebastienros
as code owners
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11726Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11726" |
|
Do we need this in the community toolkit as well? cc @aaronpowell |
davidfowl
approved these changes
Sep 30, 2025
Our last release bumped MEAI to 9.9.0, I'm not too bothered on the |
|
There is no product toolkit code that sets the property so no changes should be required: https://github.com/search?q=repo%3ACommunityToolkit%2FAspire+EnableSensitiveData&type=code |
joperezr
added
Servicing-approved
|
Low risk, fixing a new feature. Approved for 9.5.1 |
davidfowl
approved these changes
Oct 1, 2025
mitchdenny
approved these changes
Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11670 to release/9.5
/cc @JamesNK @copilot
Customer Impact
Just after 9.5 locked down
Microsoft.Extensions.AIwas updated to use theOTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENTenv var to decide the default value ofEnableSensitiveData. This property controls whether MEAI includes message content in GenAI telemetry.Unfortunately Aspire AI integrations overwrites MEAI's
EnableSensitiveDataproperty. That means its set to what the user set (good) or back to its default of false (bad, we lose the env var default).The end result is users have to manually enable sensitive data in local dev environment instead of it automatically being enabled.
Fixes in this PR:
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT. Because of layering of the current code, it was simpler to continue to overwrite MEAI'sEnableSensitiveDataproperty, but now the new value is a sensible default based on the env var.Microsoft.Extensions.AIto version that looks forOTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT. That means if someone has a reference to MEAI via our packages, but is creating the client themselves, then they'll get a consistent experience.The goal here is to make GenAI telemetry "just work" in local development without any additional configuration.
Testing
Manual testing
Risk
Low
Regression?
No