Refactor Devcontainer port forwarding logic to use a channel for updates and improve asynchronous processing. #11657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11657Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11657" |
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Devcontainer port forwarding logic to support incremental port updates rather than batch processing all endpoints upfront. The main change introduces a channel-based asynchronous processing system that can handle port forwards as they become available.
- Replaces synchronous batch processing with asynchronous channel-based updates
- Switches from
AfterEndpointsAllocatedAsyncto event-driven processing viaResourceEndpointsAllocatedEvent - Adds proper resource disposal and background task management
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DevcontainerSettingsWriter.cs | Implements channel-based processing, adds IDisposable, and refactors from batch to incremental port handling |
| DevcontainerPortForwardingLifecycleHook.cs | Changes from lifecycle hook to event subscription model for processing individual resource endpoints |
davidfowl
commented
Sep 26, 2025
davidfowl
commented
Sep 26, 2025
…tes and improve asynchronous processing. - Don't assume we have all of the endpoints up front. Support incrementally updating settings and appending ports to forward. Fixes #11654
davidfowl
force-pushed
the
davidfowl/fix-devtunnels-in-devcontainers
branch
from
5301289 to
fc3009b
Compare
mitchdenny
approved these changes
Sep 30, 2025
|
/backport to release/9.5 |
|
Started backporting to release/9.5: https://github.com/dotnet/aspire/actions/runs/18119393675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't assume we have all of the endpoints up front. Support incrementally updating settings and appending ports to forward.
Fixes #11654
Checklist