Skip to content

[release/9.4] Port Fix creating projects with GB18030 chars #11032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

[release/9.4] Port Fix creating projects with GB18030 chars #11032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<DotNetRuntimeCurrentVersionForTesting>9.0.6</DotNetRuntimeCurrentVersionForTesting>
<!-- dotnet 8.0 versions for running tests - used for templates tests -->
<DotNetSdkPreviousVersionForTesting>8.0.406</DotNetSdkPreviousVersionForTesting>
<!-- dotnet 10.0 versions for running tests - used for templates tests -->
<DotNetSdkCurrentVersionForTesting>9.0.200</DotNetSdkCurrentVersionForTesting>
<!-- dotnet 9.0 versions for running tests - used for templates tests -->
<DotNetSdkCurrentVersionForTesting>9.0.304</DotNetSdkCurrentVersionForTesting>
<XunitV3Version>3.0.0-pre.25</XunitV3Version>
<XUnitAnalyzersVersion>1.21.0</XUnitAnalyzersVersion>
<XunitRunnerVisualStudioVersion>3.1.0</XunitRunnerVisualStudioVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.ProjectTemplates/templates/aspire-empty/9.3/AspireApplication.1.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Microsoft Visual Studio Solution File, Format Version 12.00
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.8.0.0
MinimumVisualStudioVersion = 17.8.0.0
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.ProjectTemplates/templates/aspire-empty/9.4/AspireApplication.1.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Microsoft Visual Studio Solution File, Format Version 12.00
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.8.0.0
MinimumVisualStudioVersion = 17.8.0.0
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.ProjectTemplates/templates/aspire-starter/9.3/Aspire-StarterApplication.1.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Microsoft Visual Studio Solution File, Format Version 12.00
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.8.0.0
MinimumVisualStudioVersion = 17.8.0.0
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.ProjectTemplates/templates/aspire-starter/9.4/Aspire-StarterApplication.1.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Microsoft Visual Studio Solution File, Format Version 12.00
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.8.0.0
MinimumVisualStudioVersion = 17.8.0.0
Expand Down
7 changes: 1 addition & 6 deletions tests/Aspire.Templates.Tests/TemplateTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,12 +270,7 @@ public static IEnumerable<string> GetProjectNamesForTest()
{
// Avoid running these cases on PR validation

if (!OperatingSystem.IsWindows())
{
// ActiveIssue for windows: https://github.com/dotnet/aspire/issues/4555
yield return "aspire_龦唉丂荳_㐁ᠭ_ᠤསྲིདخەلꌠ_1ᥕ";
}

yield return "aspire_龦唉丂荳_㐁ᠭ_ᠤསྲིདخەلꌠ_1ᥕ项目1"; // sln should have UTF-8 byte order mark
yield return "aspire_starter.1period then.34letters";
yield return "aspire-starter & with.1";

Expand Down
Loading