Skip to content

Conversation

@maddymontaquila
Copy link
Member

@maddymontaquila maddymontaquila commented Jul 30, 2025

Description

Updated KnownResourceTypes.Parameter to Key (from single setting gear), Executable to Code (as opposed to multiple settings gears), External service to GlobeArrowForward (from cloud arrow up which is like upload).

Feels weird that exes were settings but I didn't want to change project (Code Circle) so i picked an alternative similar type. Would be cool if we could eventually use lang - like ic_fluent_code_cs_rectangle_16_regular - but theyre all only in 16px right now.

image image image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings July 30, 2025 20:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the icons used for different resource types in the Aspire Dashboard to provide better visual representation. The changes improve the user experience by making resource types more intuitive through clearer iconography.

  • Updated Parameter resources to use "Key" icon instead of single settings gear
  • Changed Executable resources to use "Code" icon instead of multiple settings gears
  • Modified External service resources to use "GlobeArrowForward" icon instead of cloud arrow up

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Dashboard/Model/ResourceIconHelpers.cs Updates icon mappings for Parameter, Executable, and ExternalService resource types
playground/publishers/.aspire/settings.json Adds Aspire configuration file with appHostPath setting
playground/TestShop/.aspire/settings.json Adds Aspire configuration file with appHostPath setting
playground/Stress/.aspire/settings.json Adds Aspire configuration file with appHostPath setting
playground/ExternalServices/.aspire/settings.json Adds Aspire configuration file with appHostPath setting

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 30, 2025
@@ -0,0 +1,3 @@
{
"appHostPath": "../ExternalServices.AppHost/ExternalServices.AppHost.csproj"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be checked in? @mitchdenny

If not, can I more strongly suggest that .aspire be added to the git ignore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be checked in. Feel free to add it to .gitignore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear - for our customers - it should generally be checked in - but in our repo it doesn't make sense since we switch between playground apps all the time.

@JamesNK
Copy link
Member

JamesNK commented Jul 30, 2025

Would be cool if we could eventually use lang - like ic_fluent_code_cs_rectangle_16_regular - but theyre all only in 16px right now.

They're SVG so they should scale up fine.

However if we just SVG for projects then it should only be if the resource source is a csproj file. I don't know what Aspire's support is like for F# projects, but if they run then I expect F# people will get very grumpy if their F# project has a C# icon.

@maddymontaquila
Copy link
Member Author

Would be cool if we could eventually use lang - like ic_fluent_code_cs_rectangle_16_regular - but theyre all only in 16px right now.

They're SVG so they should scale up fine.

However if we just SVG for projects then it should only be if the resource source is a csproj file. I don't know what Aspire's support is like for F# projects, but if they run then I expect F# people will get very grumpy if their F# project has a C# icon.

I thought about this too which is part of the reason I didn't pull the trigger on trying it out... I can live without it. Maybe when we do custom icons we could look at picking ones based on lang. TY!

@maddymontaquila
Copy link
Member Author

Nuked .aspire folders and added .aspire/ to .gitignore @mitchdenny @JamesNK !

@maddymontaquila maddymontaquila requested a review from JamesNK July 31, 2025 16:58
@JamesNK JamesNK force-pushed the maddy/parameter-and-exe-icons branch from 4cce7b1 to 997c825 Compare July 31, 2025 23:39
@JamesNK JamesNK enabled auto-merge (squash) July 31, 2025 23:40
@JamesNK JamesNK added area-dashboard and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 31, 2025
@JamesNK JamesNK merged commit 8c9ad9d into main Jul 31, 2025
275 of 276 checks passed
@JamesNK JamesNK deleted the maddy/parameter-and-exe-icons branch July 31, 2025 23:57
@davidfowl davidfowl added this to the 9.5 milestone Aug 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants