-
Notifications
You must be signed in to change notification settings - Fork 720
Exe, ext service, + param icon updates for dashboard resource view + graph #10762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the icons used for different resource types in the Aspire Dashboard to provide better visual representation. The changes improve the user experience by making resource types more intuitive through clearer iconography.
- Updated Parameter resources to use "Key" icon instead of single settings gear
- Changed Executable resources to use "Code" icon instead of multiple settings gears
- Modified External service resources to use "GlobeArrowForward" icon instead of cloud arrow up
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Model/ResourceIconHelpers.cs | Updates icon mappings for Parameter, Executable, and ExternalService resource types |
| playground/publishers/.aspire/settings.json | Adds Aspire configuration file with appHostPath setting |
| playground/TestShop/.aspire/settings.json | Adds Aspire configuration file with appHostPath setting |
| playground/Stress/.aspire/settings.json | Adds Aspire configuration file with appHostPath setting |
| playground/ExternalServices/.aspire/settings.json | Adds Aspire configuration file with appHostPath setting |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "appHostPath": "../ExternalServices.AppHost/ExternalServices.AppHost.csproj" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be checked in? @mitchdenny
If not, can I more strongly suggest that .aspire be added to the git ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be checked in. Feel free to add it to .gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear - for our customers - it should generally be checked in - but in our repo it doesn't make sense since we switch between playground apps all the time.
They're SVG so they should scale up fine. However if we just SVG for projects then it should only be if the resource source is a csproj file. I don't know what Aspire's support is like for F# projects, but if they run then I expect F# people will get very grumpy if their F# project has a C# icon. |
I thought about this too which is part of the reason I didn't pull the trigger on trying it out... I can live without it. Maybe when we do custom icons we could look at picking ones based on lang. TY! |
|
Nuked .aspire folders and added .aspire/ to .gitignore @mitchdenny @JamesNK ! |
4cce7b1 to
997c825
Compare
Description
Updated KnownResourceTypes.Parameter to Key (from single setting gear), Executable to Code (as opposed to multiple settings gears), External service to GlobeArrowForward (from cloud arrow up which is like upload).
Feels weird that exes were settings but I didn't want to change project (Code Circle) so i picked an alternative similar type. Would be cool if we could eventually use lang - like
ic_fluent_code_cs_rectangle_16_regular- but theyre all only in 16px right now.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate