Skip to content

Ensure all YARP env vars are strings #10434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Ensure all YARP env vars are strings #10434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Hosting.Yarp/YarpEnvConfigGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ private static void FlattenToEnvVars(Dictionary<string, object> environmentVaria
{
if (IsSimple(obj))
{
environmentVariables.Add(prefix, obj);
environmentVariables.Add(prefix, obj.ToString() ?? "");
}
else if (obj is IReadOnlyDictionary<string, string> dict)
{
Expand Down Expand Up @@ -74,7 +74,7 @@ private static void FlattenToEnvVars(Dictionary<string, object> environmentVaria
{
if ((sslProtocols & protocol) == protocol)
{
environmentVariables.Add($"{prefix}__{counter}", protocol);
environmentVariables.Add($"{prefix}__{counter}", protocol.ToString());
counter++;
}
}
Expand Down
17 changes: 17 additions & 0 deletions tests/Aspire.Hosting.Yarp.Tests/YarpConfigGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,23 @@ public async Task GenerateEnvVariablesConfiguration()
await Verify(content, "env");
}

[Fact]
public void EnsureAllEnvVarsAreStrings()
{
var variables = new Dictionary<string, object>();
var builder = TestDistributedApplicationBuilder.Create();

YarpEnvConfigGenerator.PopulateEnvVariables(
variables,
_validRoutes.Select(r => new YarpRoute(r)).ToList(),
_validClusters.Select(c => new YarpCluster(c, c.Destinations!.First().Value.Address)).ToList());

foreach (var variable in variables)
{
Assert.IsType<string>(variable.Value);
}
}

[Fact]
[RequiresDocker]
public async Task GenerateEnvVariablesConfigurationDockerCompose()
Expand Down
Loading