Skip to content

Add quotation marks in dashboard around arguments with spaces in them #10404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Add quotation marks in dashboard around arguments with spaces in them #10404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cafcce8
Add quotation marks in dashboard around arguments with spaces in them
adamint Jul 15, 2025
daa1dac
add FormatValue method
adamint Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions playground/Stress/Stress.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@
builder.AddProject<Projects.Aspire_Dashboard>(KnownResourceNames.AspireDashboard);
#endif

builder.AddExecutable("executableWithSingleArg", "dotnet", Environment.CurrentDirectory, "--version");
builder.AddExecutable("executableWithSingleEscapedArg", "dotnet", Environment.CurrentDirectory, "one two");
builder.AddExecutable("executableWithMultipleArgs", "dotnet", Environment.CurrentDirectory, "--version", "one two");

IResourceBuilder<IResource>? previousResourceBuilder = null;

for (var i = 0; i < 3; i++)
Expand Down
10 changes: 7 additions & 3 deletions src/Aspire.Dashboard/Components/ResourcesGridColumns/SourceColumnDisplay.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@using Aspire.Dashboard.Model
@using Aspire.Dashboard.Resources
@using Aspire.Dashboard.Resources
@using Aspire.Dashboard.Utils

@inject IStringLocalizer<Columns> Loc
Expand All @@ -21,7 +20,12 @@
{
if (launchArgument.IsShown)
{
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The nested if-else duplicates the <span> markup; consider extracting the display value into a variable (e.g., displayValue) and rendering a single <span> for cleaner, DRY code.

Copilot uses AI. Check for mistakes.
<span class="subtext">&nbsp;@launchArgument.Value</span>
<span class="subtext">@FormatValue(launchArgument.Value)</span>

static string FormatValue(string value)
{
return " " + (value.Contains(' ') ? $"\"{value}\"" : value);
Comment on lines +23 to +27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a space turns into a non-breaking space. Double check before/after that args are still properly spaced.

Suggested change
<span class="subtext">@FormatValue(launchArgument.Value)</span>
static string FormatValue(string value)
{
return " " + (value.Contains(' ') ? $"\"{value}\"" : value);
<span class="subtext">&nbsp;@FormatValue(launchArgument.Value)</span>
static string FormatValue(string value)
{
return (value.Contains(' ') ? $"\"{value}\"" : value);

}
}
else
{
Expand Down
Loading