[release/9.4] Made changes to how parameter.Value works #10357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10354 to release/9.4
/cc @davidfowl
Description
This change was motivated by issues found while testing async parameter resolution. Previously,
ParameterResource.Valuewas used in many places without properly waiting for values to resolve, causing failures. Now,ParameterResource.ValuecallsParameterResource.GetValueAsync(...).GetAwaiter().GetResult(), which—while not ideal—ensures that both sync and async access behave consistently and avoid inconsistent state.There is some risk of introducing deadlocks for consumers that previously used
.Value, but if.Valueis accessed before the TCS is set, it will throw as before.Valuenow blocks (sync over async) waiting for value resolution ifWaitForValueTcsis set.GetValueAsynconParameterResourcepublic.GetValueAsyncinstead ofValue.Fixes #10352
Customer Impact
Testing
Risk
.Valuein a deadlock-prone context; mitigated by existing exception handling.Regression?