Add Azure provisioning command handling and settings configuration #10038

davidfowl · 2025-06-25T07:27:28Z

Description

Use the new interaction service to prompt in the dashboard for subscription id and location.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- No
Does the change make any security assumptions or guarantees?
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire-docs issue (consider using one of the following templates):
- No

Improve user prompt for Azure subscription settings in provisioning context Update Azure subscription prompt to include HTML link for creating a free account

…ure-config

davidfowl · 2025-07-10T23:05:23Z

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

+                        new InteractionInput { InputType = InputType.SecretText, Label = "Subscription ID", Placeholder = "Select Subscription ID", Required = true },
+                        new InteractionInput { InputType = InputType.Text, Label = "Resource Group", Value = "GetResourceGroupDefault"},
+                    ],
+                    new InputsDialogInteractionOptions { ShowDismiss = false, EnableMessageMarkdown = true },


It should be possible to dismiss, allowing users to interact with the dashboard and other resources still.

It is possible.

The dialog looks like this:

Can you also query for subscription ids?

I can, but doing that would prevent me from entering in something that isn't in the list. I plan on openining an interaction service feature request tomorrow to support an input that allows both a list of options and the ability to enter in a free form value.

Without this, do you think for 9.4 we should leave it as-is without the list? Or should we query the for the list and show it if we found some (preventing entering something that isn't in the list)?

Are values remembered? A checkbox was added to the parameters dialog for that.

@eerhardt yes we need to save them to user secrets

It auto persists to user secrets, which I think is a good default (all of the other azure state does as well).

@eerhardt lets update the link to description to point to an aka.ms link. We can remove the Azure free account link and just use one that points to the docs.

cc @IEvangelist

It auto persists to user secrets, which I think is a good default (all of the other azure state does as well).

At one point I had a checkbox (which defaulted to true), but I removed it. My reasoning was because if you didn't save the information, when you added another Azure resource on a new run, you would get prompted again and if you choose a different Resource Group, or subscription, you'd get into a weird torn state where some resources were in one location/resourcegroup/sub and some where in another.

I think it is better to just always save the information. So you can't get into this state as easy.

- Save data to user secrets

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

davidfowl · 2025-07-11T08:41:30Z

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

+    {
+        while (_options.Location == null || _options.SubscriptionId == null)
+        {
+            var locations = typeof(AzureLocation).GetProperties(BindingFlags.Public | BindingFlags.Static)


Do we need to do this more than once ever?

@tg-msft Why do we need to reflect for this? Is there another way?

cc @vhvb1989

At least it is public reflection - and not the private reflection you had originally. 😆

It looks like you should first prompt for subscription, and then from a subscription you can get the list of locations:

var armClient = new ArmClient(credential); // Get the subscription (replace with your actual subscription ID) var subscription = await armClient.GetDefaultSubscriptionAsync(); // List all locations (regions) available for this subscription await foreach (var location in subscription.GetLocationsAsync()) { Console.WriteLine($"{location.Name} - {location.DisplayName}"); }

Need to refactor InteractionResult to allow for mocking without using IVT.

eerhardt · 2025-07-11T21:04:06Z

I believe this is ready for review now. FYI - @davidfowl @JamesNK

I had to make some changes to the public API of InteractionResult since it isn't possible to test users of the InteractionService without using IVT.

…ure-config

davidfowl · 2025-07-11T21:55:20Z

👍🏾 ship it

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

JamesNK · 2025-07-11T23:23:52Z

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

+                        EnableMessageMarkdown = true,
+                        ValidationCallback = static (validationContext) =>
+                        {
+                            var subscriptionInput = validationContext.Inputs[1];


Instead of referencing inputs by index, you could create them earlier and assign them to variables, use the variable in the array passed to PromptInputsAsync and here in the validation. The instance will be the same. It's non-obvious that you can do that.

Although I'm starting to wonder if inputs should have a name and be accessible via name here and in the result...

Keep referencing by index and in 9.5 I'll change the API to make inputs a KeyedCollection.

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

JamesNK · 2025-07-11T23:27:55Z

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs

+                            if (!IsValidResourceGroupName(resourceGroupInput.Value))
+                            {
+                                validationContext.AddValidationError(resourceGroupInput, "Resource group name must be a valid Azure resource group name.");
+                            }


This doesn't say why the name isn't valid. It's not a good user experience.

JamesNK · 2025-07-11T23:29:22Z

src/Aspire.Hosting/InteractionService.cs

                    await validationCallback(context).ConfigureAwait(false);

-                    return context.HasErrors;
+                    return !context.HasErrors;


Was this a bug?

Co-authored-by: James Newton-King <[email protected]>

… handling

davidfowl · 2025-07-12T01:06:32Z

/backport to release/9.4

github-actions · 2025-07-12T01:06:41Z

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16232571461

Add Azure provisioning command handling and settings configuration

8474f7f

Improve user prompt for Azure subscription settings in provisioning context Update Azure subscription prompt to include HTML link for creating a free account

github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 25, 2025

davidfowl added this to the 9.4 milestone Jul 9, 2025

eerhardt self-assigned this Jul 10, 2025

eerhardt added 2 commits July 10, 2025 15:42

Merge remote-tracking branch 'upstream/main' into davidfowl/prompt-az…

a30a954

…ure-config

WIP: move to message bar prompt

212649b

davidfowl commented Jul 10, 2025

View reviewed changes

- Populate a default resource group name

8c61642

- Save data to user secrets

eerhardt reviewed Jul 11, 2025

View reviewed changes

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Show resolved Hide resolved

JamesNK reviewed Jul 11, 2025

View reviewed changes

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Outdated Show resolved Hide resolved

JamesNK reviewed Jul 11, 2025

View reviewed changes

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Outdated Show resolved Hide resolved

JamesNK reviewed Jul 11, 2025

View reviewed changes

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Outdated Show resolved Hide resolved

davidfowl commented Jul 11, 2025

View reviewed changes

src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Outdated Show resolved Hide resolved

davidfowl commented Jul 11, 2025

View reviewed changes

eerhardt added 3 commits July 11, 2025 14:20

PR feedback

3886110

Tweak the dialog message

b5cc50a

Add a test

22ae194

Need to refactor InteractionResult to allow for mocking without using IVT.

eerhardt marked this pull request as ready for review July 11, 2025 21:03

eerhardt requested review from mitchdenny and radical as code owners July 11, 2025 21:03

eerhardt added 2 commits July 11, 2025 16:04

Merge remote-tracking branch 'upstream/main' into davidfowl/prompt-az…

c04d37d

…ure-config

Fix new tests for new APIs.

cb4f845

This was referenced Jul 11, 2025

Support InteractionInput.InputType with both freeform and suggested choices (useful for Azure Subscriptions) #10343

Closed

Query the list of available Azure subscriptions during provisioning prompting #10344

Open

MihuBot mentioned this pull request Jul 11, 2025

[✨ Triage] dotnet/aspire#10345 by eerhardt - Inputs dialog shows dismiss button even when ShowDismiss = false MihuBot/runtime-utils#1217

Open

Fix tests

ff44a96

eerhardt added 2 commits July 11, 2025 17:20

Add a test for PromptInputAsync with ValidationCallback

3eb91a7

Add a test for validation

a9f86e2

eerhardt approved these changes Jul 11, 2025

View reviewed changes

JamesNK reviewed Jul 11, 2025

View reviewed changes

davidfowl and others added 2 commits July 11, 2025 16:58

Apply suggestions from code review

cd84fce

Co-authored-by: James Newton-King <[email protected]>

Refactor provisioning options initialization and improve user secrets…

e9d5c92

… handling

davidfowl merged commit ab40bf0 into main Jul 12, 2025
276 checks passed

davidfowl deleted the davidfowl/prompt-azure-config branch July 12, 2025 01:06

github-actions bot mentioned this pull request Jul 12, 2025

[release/9.4] Add Azure provisioning command handling and settings configuration #10350

Merged

MihuBot mentioned this pull request Jul 12, 2025

[✨ Triage] dotnet/aspire#10343 by eerhardt - Support InteractionInput.InputType with both freeform and suggested cho ... MihuBot/runtime-utils#1218

Open

eerhardt mentioned this pull request Jul 14, 2025

[Update article]: Azure Provisioning Prompts for Subscription and Location dotnet/docs-aspire#4046

Closed

MihuBot mentioned this pull request Aug 5, 2025

[✨ Triage] dotnet/aspire#10834 by JamesNK - InteractionInputs should be accessiable by name in results MihuBot/runtime-utils#1349

Open

github-actions bot locked and limited conversation to collaborators Aug 11, 2025

Uh oh!

Add Azure provisioning command handling and settings configuration #10038

Add Azure provisioning command handling and settings configuration #10038

Uh oh!

Conversation

davidfowl commented Jun 25, 2025

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eerhardt commented Jul 11, 2025

Uh oh!

davidfowl commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JamesNK Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JamesNK Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidfowl commented Jul 12, 2025

Uh oh!

github-actions bot commented Jul 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

davidfowl Jul 11, 2025 •

edited

Loading

JamesNK Jul 11, 2025 •

edited

Loading

JamesNK Jul 11, 2025 •

edited

Loading