9.2: Relative urls to `WithUrlForEndpoint` get swallowed

[afscrome]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

If you pass a relative url to WithUrlForEndpoint, then no URLs get shown for the resource.

.WithUrlForEndpoint("http", annotation => annotation.Url = "/swagger")

Expected Behavior

Preferably, the relative url would be combined with the endpoint's url - i.e. equivalent to .WithUrlForEndpoint("http", annotation => annotation.Url = $"{annotation.Endpoint?.Url}/swagger"). Likely using new Uri(Uri baseUri, string? relativeUri) to combine the base url and the relative portion.

Alternatively if an absolute url is required, I'd expect to see some kind of error logged.

Steps To Reproduce

.WithUrlForEndpoint("http", annotation => annotation.Url = "/swagger")

Exceptions (if any)

None

.NET Version info

No response

Anything else?

cc @DamianEdwards

[davidfowl]

Doesn't seem critical for 9.2. I'll let @DamianEdwards decide.

[DamianEdwards]

Yeah we can revisit this behavior in the next release given right now it just doesn't display it at all.

[afscrome]

I'd agree on the not supporting relative urls. It's the hiding without any error pit of failure that makes me want to consider it for 9.2. Not a strongly held view though.

[DamianEdwards]

We can change it as a bug fix in 9.3

[afscrome]

Relative url support could also make for some nice simplifications to WithUrlForEndpoint. Rather than

      builder.WithUrlForEndpoint("http", url => url.Url += "/swagger")

what about:

builder.WithUrlForEndpoint("http", "/swagger");

Most of the time I'm finding all I want to do is add a subpath tot he existing url (and sometimes set displayText), without needing the full blown resource annotation.