DCP does not shut down, ephemeral Docker network not cleaned up after running tests from aspire-samples repository

[karolz-ms]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

(see title)

Expected Behavior

DCP should shut down and leave machine in clean state, including cleaning up the ephemeral Docker network.

Steps To Reproduce

1. Make sure the machine has the following prerequisites
   • Dapr 1.14+ (installed and initialized)
   • Node LTS (20.x)
   • Python 3.10+
2. Clone dotnet/aspire-samples repository
3. Build the repository and run tests

Exceptions (if any)

No response

.NET Version info

9.0 RC

Anything else?

No response

[zejji]

I am seeing this issue when developing using Aspire in normal usage - see screenshot below. These networks need cleaning up manually.

Update: On further testing, it appears Aspire never clears up any networks it creates.

My platform details:

• .NET SDK version: 9.0.100-rc.2
• Aspire version: 9.0.0-rc.1.24511.1
• Platform: Windows 11
• Docker version: Docker Desktop version: 4.34.2 (167172)

[davidfowl]

Fixed in #6560

[joperezr]

Reopening as there seem to still be some scenarios where this can be reproduced, particularly when using dotnet watch.

[karolz-ms]

The fixes included in #6560 addressed DCP internal problems.

The current version of dotnet watch kills entire process tree, including DCP, which thus does not have a chance to do the cleanup. This is a known issue that @tmat is fixing as part of the major dotnet watch renewal.

We also have the problem of DCP instances lingering during test run, which is mostly the Aspire test application builder issue, but also constrained by lack of ability to "tell" DCP to shut down before the process that launched DCP is terminated. This is tracked by #6561

Once new `dotnet watch arrives and #6561 is resolved, I do not expect any additional work to resolve the scenario described in this issue.

[davidfowl]

@karolz-ms did you expose the API to shutdown dcp explicitly after a test run?

[karolz-ms]

This should be resolved once aspire-samples repository is updated to take advantage of Aspire 9.1

[karolz-ms]

... and yes, DCP can now be shut down programmatically and Aspire ApplicationExecutor is taking advantage of that, for regular application runs and for tests.