Disable Workloads dependency on WiX nupkg during source-build to remove prebuilt #8335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the prebuilt WiX dependency: dotnet#8014 The patch is temporary, pending upstream fix and dependency flow.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source-build team is making an effort to upstream our patches this week, see dotnet/source-build#2708.
This PR removes the dependency on WiX during source-build to prevent pulling in the WiX prebuilt binary. There was previously a PR for this change that became outdated and was closed. Additionally, there is an issue tracking the WiX prebuilt that will be resolved if this patch is merged:
Summary of the changes:
.wix.csextension.wix.csextension from the build during source-build