Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] add cross supporting LoongArch64. #8333

Closed
wants to merge 1 commit into from

Conversation

shushanhf
Copy link
Contributor

add cross supporting LoongArch64.

@shushanhf
Copy link
Contributor Author

Hi, @am11
Could you review this PR please ?

@am11
Copy link
Member

am11 commented Jan 14, 2022

@shushanhf, how was this tested? As discussed previously, unless we can provide corresponding support in build-rootfs.sh, adding code for new architecture in toolchain.cmake alone does not make much sense because configuration in this file depends on the exact setup done by rootfs script.

@shushanhf
Copy link
Contributor Author

@shushanhf, how was this tested? As discussed previously, unless we can provide corresponding support in build-rootfs.sh, adding code for new architecture in toolchain.cmake alone does not make much sense because configuration in this file depends on the exact setup done by rootfs script.

OK, Thanks.
I will upload it after the corresponding upstream supports LoongArch64.

@am11
Copy link
Member

am11 commented Jan 14, 2022

For reference, riscv64 support was initially added in llvm9 (current version is llvm13) and we are still waiting for dependencies like lldb. Therefore, I haven't pushed that change yet. LoongArch64 support is not even available in vanilla llvm13 toolchain, so I think we can wait at least until patches are merged in its mainline. Then look to port other dependencies (krb5, openssl, lttng-ust, lldb, omp5 etc.) along with our preferred debootstrap tool used on Debian, before changing rootfs script.

TL;DR, there is no rush for upstreaming cross-build setup right now.

@shushanhf
Copy link
Contributor Author

For reference, riscv64 support was initially added in llvm9 (current version is llvm13) and we are still waiting for dependencies like lldb. Therefore, I haven't pushed that change yet. LoongArch64 support is not even available in vanilla llvm13 toolchain, so I think we can wait at least until patches are merged in its mainline. Then look to port other dependencies (krb5, openssl, lttng-ust, lldb, omp5 etc.) along with our preferred debootstrap tool used on Debian, before changing rootfs script.

Thanks for your advices.
Are qemu and docker's image also needed ?

Now all these can only be getted throuth the pulic patches or mirrors which are still be pushing to upstream.

@am11
Copy link
Member

am11 commented Jan 14, 2022

Now all these can only be getted throuth the pulic patches or mirrors which are still be pushing to upstream.

Unreviewed / unmerged patches are something you can use in your local setup for the initial bootstrap. You can create your own docker container with prerequisites to build dotnet-runtime and share it with people who are interested, but unless dependencies get loongarch64 support upstream, it is not something we should push in arcade; the .NET engineering infrastructure (I think rust engineering infra has the similar requirements for new platforms).

xen0n added a commit to xen0n/dotnet-arcade that referenced this pull request Dec 1, 2024
Debian-like systems where CHOST="loongarch64-linux-gnu" and Alpine
(CHOST="loongarch64-alpine-linux-musl") are supported.

Supersedes dotnet#8333.
@akoeplinger
Copy link
Member

Superseded by #15370

@akoeplinger akoeplinger closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants