Fix feed creation for dnceng-stage and staging scenarios #8082
Conversation
- Don't call GetFeedVisibilityTag when the feed name is explicitly specified - Alter GetFeedVisibilityTag to support non-dnceng - Alter the default permissions setup method to specify null permissions for non-dnceng
| default: | ||
| throw new NotImplementedException($"Organization '{organization}' contains no feed permissions information."); | ||
| // Use the default permissions | ||
| Permissions = null; |
There was a problem hiding this comment.
@jonfortescue can you take a look at this bit? My recollection is that you changed some stuff around permissions for dnceng-stage, and I want to make sure this captures the change you had made
There was a problem hiding this comment.
The previous implementation of this had no permissions setup for anything but dnceng, so this effectively goes back to that: https://github.com/dotnet/arcade/pull/7700/files
There was a problem hiding this comment.
Yep, this looks fine to me -- this is exactly how it's supposed to be.
michellemcdaniel
left a comment
michellemcdaniel
left a comment
There was a problem hiding this comment.
Thanks for the changes. Just want to confirm with Jon that he doesn't expect anything for dnceng-stage to break with this (looking at it, I don't expect it to based on the PR he made to enable dnceng-stage, but I just want to have him take a look).
jonfortescue
left a comment
jonfortescue
left a comment
There was a problem hiding this comment.
Doesn't look like anything will break to me!
3 participants
To double check: