[release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine #8003
Conversation
dotnet#8000) * Use WIX_NATIVE_MACHINE to detect native architecture of target machine * Reference WIX_NATIVE_MACHINE property
|
This was approved over email. Could I have a review and merge? |
|
Are you updating the workload task's templates separately, or is that already completed? |
|
Can you clarify what you mean by that? The source file is shared between installers and workloads package. I spot checked the places we consume that file and made sure they pass the extension. Is there something I missed? It's quite possible since those only build in official builds of runtime and we did miss something there before, but I tried to be diligent about that. |
Sorry we're good, I forgot you linked that file into the workload task's .csproj |
|
@mmitche @markwilkie can I get a merge on this? It was approved over email yesterday. |
3 participants
Customer Impact
Reliably detect machine architecture
Testing
Manually built and consumed changes, built installer in runtime and tested to validate behavior.
Risk
Low - we don't expect this to break anything, but it requires coordination across repositories and adds a new component to the installers including a custom action DLL which we didn't previously use.