Skip to content

Request retry+reboot when Apple app installation hangs #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
premun merged 1 commit into from
Sep 27, 2021
Merged

Request retry+reboot when Apple app installation hangs #7966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAppleWorkItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static class MetadataNames
private const string EntryPointScript = "xharness-helix-job.apple.sh";
private const string RunnerScript = "xharness-runner.apple.sh";

private static readonly TimeSpan s_defaultLaunchTimeout = TimeSpan.FromMinutes(10);
private static readonly TimeSpan s_defaultLaunchTimeout = TimeSpan.FromMinutes(5);

/// <summary>
/// An array of one or more paths to iOS/tvOS app bundles (folders ending with ".app" usually)
Expand Down
8 changes: 8 additions & 0 deletions src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-runner.apple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,14 @@ if [ $exit_code -eq 81 ] && [[ "$target" =~ "device" ]]; then
touch './.reboot'
fi

# Simulators are known to slow down which results in installation taking several minutes
# Retry+reboot usually resolves this
# 86 - app installation timeout
if [ $exit_code -eq 86 ]; then
touch './.retry'
touch './.reboot'
fi

# The simulator logs comming from the sudo-spawned Simulator.app are not readable/deletable by the helix uploader
chmod -R 0766 "$output_directory"

Expand Down