Update symboluploader to work around tracing NullRefs #7964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikem8361
approved these changes
Sep 26, 2021
riarenas
approved these changes
Sep 27, 2021
Contributor
riarenas
left a comment
riarenas
left a comment
There was a problem hiding this comment.
Should we attempt to re-enable the symuploader subscription so that these come automatically via Maestro?
2 tasks
MattGal
approved these changes
Sep 27, 2021
epananth
approved these changes
Sep 27, 2021
Member
epananth
left a comment
epananth
left a comment
There was a problem hiding this comment.
There is a merge conflict.. :/
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7924
This works around some issues in flow of activity IDs in the logging that cause a nullref in a symbol publishing operation. Ignore logging the ID when it is null.