Rename test nupkg assets #7959
Merged
Rename test nupkg assets #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids conflict with packages in nuget.org
michellemcdaniel
approved these changes
Sep 24, 2021
Contributor
|
Looks like at least the build is still looking for the actual assets to be present. Since these tests have been disabled for over 2 years, should we just remove them? |
Member
Author
Whoops. Gitignore ignores *.nupkg, and I didn't catch that these were not added. Now fixed.
I lean to keeping them here (but am totally open to discussion on it). I'd much rather see the tests fixed and this keeps all the information in its best state for that to happen. |
riarenas
approved these changes
Sep 24, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids conflict with packages in nuget.org causing SDL warnings.
These are only test assets so no functionality change. Also, these tests are disabled (see #3794).