Skip to content

Drop support for EOL alpine 3.9 #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 1 commit into from
Sep 13, 2021
Merged

Drop support for EOL alpine 3.9 #7849

ViktorHofer merged 1 commit into from
Sep 13, 2021

Conversation

@am11
Copy link
Member

@am11 am11 commented Sep 8, 2021

  • Remove 3.9.
  • Set 3.13 as default.
  • Add 3.14.

@am11
Drop support for EOL alpine 3.9
ed1dc1c 
* Remove 3.9.
* Set 3.13 as default.
* Add 3.14.
@am11
Copy link
Member Author

am11 commented Sep 8, 2021

cc @ViktorHofer, @janvorli based on https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.md#linux, we are currently only supporting Alpine 3.13 onwards. This PR sets default version to 3.13. I will send a subsequent PR to dotnet-buildtools-prereqs-docker so we get updated tags for both crossbuild arm (which is currently using 3.13) and crossbuild arm64 (which is currently using 3.9). We have already updated WithNode and helix to 3.13 and added 3.14 in docker matrix.

janvorli
janvorli approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@am11
Copy link
Member Author

am11 commented Sep 13, 2021 •
edited
Loading

@ViktorHofer, this and dotnet/runtime#57324 are related (but not dependent) and ready for review/merge. :)

dotnet/runtime#57324 is:

  • WithNode: used for building x64 binaries.
  • helix: used for testing x64, arm64, arm.

This PR + the future dotnet-prereq PRs with this change and runtime PRs consuming the updated Ubuntu image:

  • crossbuild: used for cross-building arm64 and arm binaries.

so it turned out, that "alpine update" story has a long tail than I imagined. 😅

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 13, 2021

Thanks for the great work again @am11 👍

@ViktorHofer ViktorHofer merged commit 5bd3776 into dotnet:main Sep 13, 2021
@am11 am11 mentioned this pull request Sep 13, 2021
Merged
@am11 am11 deleted the feature/alpine-3.13 branch September 13, 2021 13:31
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11 @ViktorHofer @janvorli