Skip to content

Conversation

@joeloff
Copy link
Member

@joeloff joeloff commented Sep 2, 2021

No description provided.

@joeloff joeloff requested a review from pjcollins September 2, 2021 20:22
@pjcollins
Copy link
Member

Hoping this will address our Android issues as well (my previous fix attempt helped locally but didn't fix CI) -- I built this locally and hacked together a test run here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5165781&view=results

@pjcollins
Copy link
Member

This didn't seem to work for Android still, I put up #7857 to workaround for now.

lock (msiTaskItemsLock)
{
msis.AddRange(msiItems);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And on line 116 for completeness? Usually easier to just lock all access to an object rather than rationalize which.

@joeloff
Copy link
Member Author

joeloff commented Jul 26, 2023

@pjcollins this PR got completely lost. We've completely rewritten workload tasks over the last year. Are you still seeing issues or can I close this?

@pjcollins
Copy link
Member

@joeloff I think we can close this, we haven't been having issues with the newer CreateVisualStudioWorkload task.

@missymessa missymessa closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants