Skip validating submodules sourcelinks #7784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, sourcelink is broken for submodules, where it will assume that the link is actually in the current repo, rather than having info based on the actual repo the submodule came from. There is work to fix submodule links in sourcelink, but until that fix is in, we should just ignore all links are from submodules.
epananth
reviewed
Aug 24, 2021
| if ($Uri.AbsoluteURI -ne $null -and ($Uri.Host -match 'github' -or $Uri.Host -match 'githubusercontent')) { | ||
| if ($Link -match "submodules") { | ||
| # Skip submodule links until sourcelink properly handles submodules | ||
| $Status = 200 |
Member
There was a problem hiding this comment.
Should we add the link to that issue here?
epananth
approved these changes
Aug 24, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sourcelink is broken for submodules, where it will assume that the link is actually in the current repo, rather than having info based on the actual repo the submodule came from. There is work to fix submodule links in sourcelink, but until that fix is in, we should just ignore all links are from submodules.
To double check: