Skip to content

Fix Android retry/reboot in Helix SDK #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
premun merged 2 commits into from
Aug 20, 2021
Merged

Fix Android retry/reboot in Helix SDK #7771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e667198
Fix Android retry/reboot in Helix SDK
premun Aug 20, 2021
80fde53
Improve comments for PowerShell version
premun Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,19 @@ reboot=false

# Too see where these values come from, check out https://github.com/dotnet/xharness/blob/master/src/Microsoft.DotNet.XHarness.Common/CLI/ExitCode.cs
# Avoid any helix-ism in the Xharness!
ADB_DEVICE_ENUMERATION_FAILURE=85
PACKAGE_INSTALLATION_FAILURE=78

case "$exit_code" in
85)
$ADB_DEVICE_ENUMERATION_FAILURE)
# This handles issues where devices or emulators fail to start.
# The only solution is to reboot the machine, so we request a work item retry + agent reboot when this happens
echo 'Encountered ADB_DEVICE_ENUMERATION_FAILURE. This is typically not a failure of the work item. We will run it again and reboot this computer to help its devices'
echo 'If this occurs repeatedly, please check for architectural mismatch, e.g. sending arm64_v8a APKs to an x86_64 / x86 only queue.'
retry=true
reboot=true
;;
78)
$PACKAGE_INSTALLATION_FAILURE)
# This handles issues where APKs fail to install.
# We already reboot a device inside XHarness and now request a work item retry when this happens
echo 'Encountered PACKAGE_INSTALLATION_FAILURE. This is typically not a failure of the work item. We will try it again on another Helix agent'
Expand All @@ -100,16 +102,12 @@ case "$exit_code" in
;;
esac



ADB_DEVICE_ENUMERATION_FAILURE=85
if [ "$retry"]; then
if [ "$retry" == true ]; then
Comment thread
premun marked this conversation as resolved.
"$HELIX_PYTHONPATH" -c "from helix.workitemutil import request_infra_retry; request_infra_retry('Retrying because we could not enumerate all Android devices')"
fi

PACKAGE_INSTALLATION_FAILURE=78
if [ $exit_code -eq PACKAGE_INSTALLATION_FAILURE ]; then
"$HELIX_PYTHONPATH" -c "from helix.workitemutil import request_reboot; request_reboot('Rebooting to allow Android emulator or device to restart.')"
if [ "$reboot" == true ]; then
"$HELIX_PYTHONPATH" -c "from helix.workitemutil import request_reboot; request_reboot('Rebooting to allow Android emulator to restart')"
fi

exit $exit_code