-
Notifications
You must be signed in to change notification settings - Fork 377
Work around implicit usings breaking change #7745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
makes sense to me - adding @mmitche as an fyi |
|
This is going to break dotnet/aspnetcore because we are intentionally ahead of Arcade on SDK versions and have already reacted to the implicit |
|
What does it mean for y'all @dougbu when the implicit using switches to opt in instead of opt out? (that change is on the way I hear) |
|
Tagging @DamianEdwards and @pranavkm |
|
AspNetCore is on a newer SDK that no longer uses this switch. This shouldn't affect AspNetCore any more. |
|
Is this getting undone? |
|
Poking at this to see what next steps (if any) should be taken given the defaults change. |
|
Repo owners must remove the original flag, if it was set in their repos explicitly. Other than that I can't think of anything else. |
|
Yeah, we should revert this. |
This reverts commit 5f00dd2.
Work around dotnet/sdk#19521
Without this workaround Arcade update breaks builds, e.g. https://github.com/dotnet/sourcelink/pull/729/checks?check_run_id=3280200935