Skip to content

Conversation

@tmat
Copy link
Member

@tmat tmat commented Aug 12, 2021

@markwilkie
Copy link
Member

makes sense to me - adding @mmitche as an fyi

@tmat tmat enabled auto-merge (squash) August 12, 2021 18:41
@tmat tmat merged commit 5f00dd2 into main Aug 12, 2021
@dougbu
Copy link
Contributor

dougbu commented Aug 12, 2021

This is going to break dotnet/aspnetcore because we are intentionally ahead of Arcade on SDK versions and have already reacted to the implicit usings change. /cc @dotnet/aspnet-build

@markwilkie
Copy link
Member

markwilkie commented Aug 12, 2021

What does it mean for y'all @dougbu when the implicit using switches to opt in instead of opt out? (that change is on the way I hear)

dotnet/sdk#19599

@tmat tmat deleted the dev/tmat/implicitusings branch August 12, 2021 22:33
@Pilchie
Copy link
Member

Pilchie commented Aug 13, 2021

Tagging @DamianEdwards and @pranavkm

@dougbu
Copy link
Contributor

dougbu commented Aug 16, 2021

What does it mean for y'all @dougbu when the implicit using switches to opt in instead of opt out? (that change is on the way I hear)

It means we need to flip some logic in dotnet/aspnetcore. I'm not sure if that's already happened. @wtgodbe

@pranavkm
Copy link
Contributor

pranavkm commented Aug 16, 2021

AspNetCore is on a newer SDK that no longer uses this switch. This shouldn't affect AspNetCore any more.

@RussKie
Copy link
Contributor

RussKie commented Aug 18, 2021

Is this getting undone?

@markwilkie
Copy link
Member

Poking at this to see what next steps (if any) should be taken given the defaults change.

@RussKie
Copy link
Contributor

RussKie commented Sep 5, 2021

Repo owners must remove the original flag, if it was set in their repos explicitly. Other than that I can't think of anything else.
/cc: @DamianEdwards

@markwilkie
Copy link
Member

Thanks @RussKie - @tmat, should this be reverted then in Arcade?

@tmat
Copy link
Member Author

tmat commented Sep 15, 2021

Yeah, we should revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants