Support packing new R2R maps to SFX packages #7738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
force-pushed
the
juhoyosa/support-both-perfmap-formats
branch
from
a17b5a9 to
cab3074
Compare
| <FilesToPackage Include="@(ResolvedFileToPublish)" Exclude="@(RuntimePackAsset)" /> | ||
| <FilesToPackage Condition="'%(FilesToPackage.AssetType)' == 'native'" IsNative="true" /> | ||
| <_r2rSymbolFiles Include="@(ResolvedFileToPublish->'%(RootDir)%(Directory)%(FileName).ni.pdb')" /> | ||
| <_r2rV1MapFiles Include="@(ResolvedFileToPublish->'%(RootDir)%(Directory)%(FileName).ni.r2rmap')" /> |
Member
There was a problem hiding this comment.
Can we add comments around here as well for the different type of files like the comments added below? Would make it easier to evolve this as time goes on (and possibly remove the crossgen1 support for TFMs where only crossgen2 exists).
Member
Author
There was a problem hiding this comment.
Crossgen2 can generate both files. Right now they differ mostly by name.
jkoritzinsky
approved these changes
Aug 11, 2021
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
One comment. Otherwise LGTM
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for v1 perfmaps in shared framework.
cc: @brianrob @trylek @tommcdon