Skip to content

Exclude inboxed analyzers from VerifyClosure task #7624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattGal merged 1 commit into from
Jul 15, 2021
Merged

Exclude inboxed analyzers from VerifyClosure task #7624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,9 @@

<ItemGroup Condition="'$(PlatformPackageType)' == 'RuntimePack'">
<IgnoredReference Include="@(RuntimePackAsset->'%(FileName)')" />
<!-- Ignore inboxed analyzers -->
<IgnoredReference Include="@(Reference->'%(FileName)')"

@ericstj ericstj Jul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzers shouldn’t be raised as references. They are not listed as references in the framework list. This is only happening because you are making an old SDK use a new ref pack. This can go away once you pick up a Preview7 SDK with dotnet/sdk@07768a0#diff-1b35791f7e51f6b95005b2fb7aa5e65ceca0d11578158af081003c91d97b4373R80

This workaround Is fine for now, but please delete it once you update the SDK.

Condition="$([System.String]::Copy('%(FullPath)').IndexOf('analyzers')) > 0"/>
</ItemGroup>

<ItemGroup Condition="'$(PlatformPackageType)' == 'TargetingPack'">
Expand Down